Remove ChatKind abstraction

Author: oandregal

src/chat-actions.ts

@@ -1,8 +1,8 @@
 /**
  * Single source of truth for chat starter actions. Both the empty-state
- * cards and the "+" menu render from this list, and `ChatKind` /
- * `PromptName` in src/types.ts derive their enum members from it — adding
- * a new starter is one entry here plus a `resources/prompts/<id>.md` file.
+ * cards and the "+" menu render from this list, and `PromptName` in
+ * src/types.ts derives its enum members from it — adding a new starter is
+ * one entry here plus a `resources/prompts/<id>.md` file.
  */
 
 export type ChatAction = {

src/main/channels/chat-create.ts

@@ -5,23 +5,18 @@ import { z } from 'zod';
 import { defineChannel } from './utils/define-channel';
 import { resolveProjectPath, touchMeta } from './utils/chat-store';
 import { IpcChannels } from '.';
-import { ChatKind } from '../../types';
 
 export const chatCreate = defineChannel( {
 	name: IpcChannels.chatCreate,
 	input: z.object( {
 		projectId: z.string().min( 1 ),
-		kind: ChatKind.optional(),
 		title: z.string().optional(),
 	} ),
-	handle: ( { projectId, kind, title } ) => {
+	handle: ( { projectId, title } ) => {
 		const projectPath = resolveProjectPath( projectId );
 		if ( ! projectPath ) {
 			return null;
 		}
-		return touchMeta( projectPath, randomUUID(), {
-			kind: kind ?? 'general',
-			title,
-		} );
+		return touchMeta( projectPath, randomUUID(), { title } );
 	},
 } );

src/main/channels/utils/chat-store.ts

@@ -49,10 +49,8 @@ export function readMetaFile( projectPath: string ): ChatsMetaFile {
 		if ( ! Array.isArray( parsed.chats ) ) {
 			return { chats: [] };
 		}
-		// Normalize legacy entries that predate `kind`.
 		const chats: ChatMeta[] = parsed.chats.map( ( c ) => ( {
 			id: c.id,
-			kind: c.kind ?? 'general',
 			title: c.title,
 			sessionId: c.sessionId ?? null,
 			createdAt: c.createdAt ?? 0,
@@ -87,30 +85,22 @@ export function removeChat( projectPath: string, chatId: string ): boolean {
 export function touchMeta(
 	projectPath: string,
 	chatId: string,
-	patch: Partial<
-		Pick< ChatMeta, 'sessionId' | 'lastMessageAt' | 'kind' | 'title' >
-	>
+	patch: Partial< Pick< ChatMeta, 'sessionId' | 'lastMessageAt' | 'title' > >
 ): ChatMeta {
 	const data = readMetaFile( projectPath );
 	let chat = data.chats.find( ( c ) => c.id === chatId );
 	const now = Date.now();
 	if ( ! chat ) {
 		chat = {
 			id: chatId,
-			kind: patch.kind ?? 'general',
 			title: patch.title,
 			sessionId: null,
 			createdAt: now,
 			lastMessageAt: null,
 		};
 		data.chats.push( chat );
-	} else {
-		if ( patch.kind !== undefined ) {
-			chat.kind = patch.kind;
-		}
-		if ( patch.title !== undefined ) {
-			chat.title = patch.title;
-		}
+	} else if ( patch.title !== undefined ) {
+		chat.title = patch.title;
 	}
 	if ( patch.sessionId !== undefined ) {
 		chat.sessionId = patch.sessionId;

src/preload/preload.ts

@@ -3,7 +3,6 @@ import { contextBridge, ipcRenderer } from 'electron';
 import { IpcChannels } from '../main/channels';
 import type {
 	AgentEvent,
-	ChatKind,
 	ChatMeta,
 	DirEntry,
 	PersistedMessage,
@@ -52,11 +51,10 @@ const api = {
 	chat: {
 		create: (
 			projectId: string,
-			options: { kind?: ChatKind; title?: string } = {}
+			options: { title?: string } = {}
 		): Promise< ChatMeta | null > =>
 			ipcRenderer.invoke( IpcChannels.chatCreate, {
 				projectId,
-				kind: options.kind,
 				title: options.title,
 			} ),
 		load: (

src/renderer/App.tsx

@@ -219,9 +219,7 @@ export function App(): React.ReactElement {
 		void ( async () => {
 			let chats = await window.api.chats.list( projectId );
 			if ( chats.length === 0 ) {
-				const created = await window.api.chat.create( projectId, {
-					kind: 'general',
-				} );
+				const created = await window.api.chat.create( projectId );
 				if ( created ) {
 					chats = [ created ];
 				}
@@ -558,7 +556,6 @@ export function App(): React.ReactElement {
 		const [ prompt, chat ] = await Promise.all( [
 			window.api.prompt.get( name, projectId ),
 			window.api.chat.create( projectId, {
-				kind: name,
 				title: action.chatTitle,
 			} ),
 		] );
@@ -588,9 +585,7 @@ export function App(): React.ReactElement {
 			return;
 		}
 		const projectId = activeProjectId;
-		const created = await window.api.chat.create( projectId, {
-			kind: 'general',
-		} );
+		const created = await window.api.chat.create( projectId );
 		if ( ! created ) {
 			return;
 		}

src/types.ts

@@ -16,12 +16,8 @@ import { CHAT_ACTION_IDS } from './chat-actions';
 export const PromptName = z.enum( CHAT_ACTION_IDS );
 export type PromptName = z.infer< typeof PromptName >;
 
-export const ChatKind = z.enum( [ 'general', ...CHAT_ACTION_IDS ] );
-export type ChatKind = z.infer< typeof ChatKind >;
-
 export const ChatMeta = z.object( {
 	id: z.string().min( 1 ),
-	kind: ChatKind,
 	title: z.string().optional(),
 	sessionId: z.string().nullable(),
 	createdAt: z.number(),

tests/e2e/chats.spec.ts

@@ -53,14 +53,12 @@ test.describe( 'chats UI: per-project tab strip + New chat', () => {
 				chats: [
 					{
 						id: 'seeded-a',
-						kind: 'general',
 						sessionId: null,
 						createdAt: 1,
 						lastMessageAt: 2,
 					},
 					{
 						id: 'seeded-b',
-						kind: 'general',
 						sessionId: null,
 						createdAt: 3,
 						lastMessageAt: 4,

tests/e2e/projects.spec.ts

@@ -67,7 +67,6 @@ test.describe( 'projects UI + per-project state', () => {
 					chats: [
 						{
 							id: chatId,
-							kind: 'general',
 							sessionId: null,
 							createdAt: 1,
 							lastMessageAt: 1 + messages.length,
@@ -109,7 +108,6 @@ test.describe( 'projects UI + per-project state', () => {
 				chats: [
 					{
 						id: 'chat-b',
-						kind: 'general',
 						sessionId: null,
 						createdAt: 1,
 						lastMessageAt: 999,

tests/unit/chat.spec.ts

@@ -22,20 +22,15 @@ import {
 	resolveProjectPath,
 	touchMeta,
 } from '../../src/main/channels/utils/chat-store';
-import type { ChatKind } from '../../src/types';
 
 const PROJECT_ID = 'project-a';
 
-function createChat(
-	projectId: string,
-	kind: ChatKind = 'general',
-	title?: string
-) {
+function createChat( projectId: string, title?: string ) {
 	const projectPath = resolveProjectPath( projectId );
 	if ( ! projectPath ) {
 		return null;
 	}
-	return touchMeta( projectPath, randomUUID(), { kind, title } );
+	return touchMeta( projectPath, randomUUID(), { title } );
 }
 
 function listChats( projectId: string ) {
@@ -56,13 +51,13 @@ describe( 'chat-store: multi-chat per project', () => {
 	} );
 
 	test( 'touchMeta produces distinct ids and they appear in readMetaFile', () => {
-		const a = createChat( PROJECT_ID, 'ideas', 'Ideas' );
-		const b = createChat( PROJECT_ID, 'draft', 'Draft' );
+		const a = createChat( PROJECT_ID, 'Ideas' );
+		const b = createChat( PROJECT_ID, 'Draft' );
 		expect( a ).not.toBeNull();
 		expect( b ).not.toBeNull();
 		expect( a!.id ).not.toBe( b!.id );
-		expect( a!.kind ).toBe( 'ideas' );
-		expect( b!.kind ).toBe( 'draft' );
+		expect( a!.title ).toBe( 'Ideas' );
+		expect( b!.title ).toBe( 'Draft' );
 
 		const list = listChats( PROJECT_ID );
 		expect( list ).toHaveLength( 2 );
@@ -119,10 +114,10 @@ describe( 'chat-store: multi-chat per project', () => {
 		expect( bLog ).not.toContain( 'hello-a' );
 	} );
 
-	test( 'readMetaFile normalizes legacy entries that predate the kind field', () => {
-		// Write a pre-migration chats.json: no `kind` key.
+	test( 'readMetaFile drops unknown keys (legacy entries with kind still load)', () => {
 		const legacyChat = {
 			id: DEFAULT_CHAT_ID,
+			kind: 'general',
 			sessionId: 'legacy-session',
 			createdAt: 1000,
 			lastMessageAt: 2000,
@@ -137,7 +132,6 @@ describe( 'chat-store: multi-chat per project', () => {
 		const list = listChats( PROJECT_ID );
 		expect( list ).toHaveLength( 1 );
 		expect( list[ 0 ].id ).toBe( DEFAULT_CHAT_ID );
-		expect( list[ 0 ].kind ).toBe( 'general' );
 		expect( list[ 0 ].sessionId ).toBe( 'legacy-session' );
 	} );