DYN-8631 - Block UndoRedo Operation During Cluster Prediction#16157
DYN-8631 - Block UndoRedo Operation During Cluster Prediction#16157johnpierson merged 9 commits intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8631
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Some comments then LGTM
| var node = PortViewModel.NodeViewModel; | ||
|
|
||
| //unlock undo/redo | ||
| node.WorkspaceViewModel.Model.UndoRedoLocked = false; |
There was a problem hiding this comment.
This is fine for now, we could also make it more granular in the future, similar to how undorecorder that the period of the lock is maintained by a living cycle of an object instead of bool setting by the coder. Something to think about
There was a problem hiding this comment.
Let me take a look at this. I think I might have some ideas.
There was a problem hiding this comment.
I might file a task for "As a dev, I want to add a new run state to dynamo graphs for 'is autocompleting'" or something along those lines.
johnpierson
force-pushed
the
undoRedoBlock
branch
from
34c2468 to
1c77a83
Compare
johnpierson
force-pushed
the
undoRedoBlock
branch
from
1c77a83 to
0d3e0df
Compare
|
Thank you @johnpierson Will take another look soon |
| get { return ((null != undoRecorder) && undoRecorder.CanUndo); } | ||
| get | ||
| { | ||
| return ((null != undoRecorder) && undoRecorder.CanUndo) && !IsUndoRedoLocked; |
There was a problem hiding this comment.
Looks like an extra set of bracket there can be removed..
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with one comment
3 participants
Purpose
This PR aims to address the issue, DYN-8631, by disabling the undo/redo process while iterating through cluster results. Additionally, this PR enables preselection of the nodes created by the cluster.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
@chubakueno, @QilongTang,
FYIs
@Jingyi-Wen , @Amoursol , @achintyabhat