Skip to content

DYN-8605: dock button functionality#16159

Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom
chubakueno:feature/docking_button
Apr 22, 2025
Merged

DYN-8605: dock button functionality#16159
QilongTang merged 1 commit intoDynamoDS:masterfrom
chubakueno:feature/docking_button

Conversation

@chubakueno
Copy link
Copy Markdown
Contributor

@chubakueno chubakueno commented Apr 22, 2025

Purpose

Enable docking button functionality for the cluster autocomplete flyout.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Enable the docking button for the cluster autocomplete flyout.

Reviewers

@BogdanZavu
@johnpierson

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@chubakueno chubakueno changed the title dock button functionality DYN-8605: dock button functionality Apr 22, 2025
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8605

@QilongTang
Copy link
Copy Markdown
Contributor

@johnpierson johnpierson self-requested a review April 22, 2025 17:36
Copy link
Copy Markdown
Member

@johnpierson johnpierson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and it looks like that test @QilongTang started passed.

@QilongTang QilongTang merged commit 44d2894 into DynamoDS:master Apr 22, 2025
38 of 41 checks passed
@QilongTang
Copy link
Copy Markdown
Contributor

lgtm, and it looks like that test @QilongTang started passed.

Indeed, merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants