Skip to content

CometLogger does not write logs in offline mode #21617

@rroessler1

Description

@rroessler1

Bug description

Expected: CometLogger should save logs locally to a zipfile when initialized with online=False.

Actual: It doesn't. It doesn't log anything.

Reason: It seems to be lines 274-275 here. It's setting disabled to true. Looks like a typo. I checked the git blame and didn't see any reason for this.

Fix: Deleting lines 274-275 fixes it.

I can put up a PR, just might not have time for a few days.

What version are you seeing the problem on?

v2.5

Reproduced in studio

No response

How to reproduce the bug

CometLogger(..., online=False)

Error messages and logs

# Error messages and logs here please

Environment

Current environment
#- PyTorch Lightning Version (e.g., 2.5.0):
#- PyTorch Version (e.g., 2.5):
#- Python version (e.g., 3.12):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):

More info

No response

cc @ethanwharris

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingneeds triageWaiting to be triaged by maintainersver: 2.5.x

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions