Skip to content

Commit d6cf61f

Browse files
fix: don't swallow exceptions in bulk ingestion
1 parent 4be2de4 commit d6cf61f

File tree

1 file changed

+16
-17
lines changed

1 file changed

+16
-17
lines changed

src/shared/management/commands/ingest_bulk_cve.py

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -144,30 +144,29 @@ def handle(self, *args: str, **kwargs: Any) -> None: # pyright: ignore reportUn
144144
self.stderr.write(
145145
f"Could not split year field from CVE ID '{name}': {e}" # noqa
146146
)
147+
continue
147148
except ValueError as e:
148149
self.stderr.write(
149150
f"Could not parse year from '{name}': {e}" # noqa
150151
)
152+
continue
151153

152154
# Precise-path: Check metadata dateUpdated/datePublished
153155
with open(j_cve) as fc:
154-
try:
155-
cve_json = json.load(fc)
156-
metadata = cve_json.get("cveMetadata", {})
157-
cve_date_str = metadata.get("dateUpdated") or metadata.get(
158-
"datePublished"
159-
)
160-
if cve_date_str:
161-
# Handle potential milliseconds/Z/offsets (ISO 8601)
162-
cve_date = date.fromisoformat(cve_date_str.split("T")[0])
163-
if not (from_date <= cve_date <= to_date):
164-
continue
165-
166-
make_cve(cve_json, triaged=False)
167-
count += 1
168-
print(".", end="", flush=True)
169-
except (json.JSONDecodeError, ValueError, KeyError):
170-
pass
156+
cve_json = json.load(fc)
157+
metadata = cve_json.get("cveMetadata", {})
158+
cve_date_str = metadata.get("dateUpdated") or metadata.get(
159+
"datePublished"
160+
)
161+
if cve_date_str:
162+
# Handle potential milliseconds/Z/offsets (ISO 8601)
163+
cve_date = date.fromisoformat(cve_date_str.split("T")[0])
164+
if not (from_date <= cve_date <= to_date):
165+
continue
166+
167+
make_cve(cve_json, triaged=False)
168+
count += 1
169+
print(".", end="", flush=True)
171170

172171
print() # Final newline after progress dots
173172
logger.info(f"{count} CVEs ingested.")

0 commit comments

Comments
 (0)