Skip to content

Commit f258cdf

Browse files
committed
Revert "fix: guard suggestion views against missing cached values (#829)"
This reverts commit 2705795.
1 parent 2705795 commit f258cdf

File tree

3 files changed

+1
-59
lines changed

3 files changed

+1
-59
lines changed

src/webview/suggestions/views/detail.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66
from django.views.generic import DetailView, View
77

88
from shared.auth import user_can_edit_suggestion
9-
from shared.listeners.cache_suggestions import cache_new_suggestions
109
from shared.logs.fetchers import fetch_suggestion_events
11-
from shared.models.cached import CachedSuggestions
1210
from shared.models.issue import NixpkgsIssue
1311
from shared.models.linkage import (
1412
CVEDerivationClusterProposal,
@@ -39,8 +37,6 @@ def get_context_data(self, **kwargs: Any) -> dict[str, Any]:
3937

4038
def get(self, request: HttpRequest, suggestion_id: int) -> HttpResponse:
4139
self.object = self.get_object()
42-
if not CachedSuggestions.objects.filter(proposal=self.object).exists():
43-
cache_new_suggestions(self.object) # type: ignore
4440
if self.object.status == CVEDerivationClusterProposal.Status.PUBLISHED:
4541
issue = NixpkgsIssue.objects.get(suggestion=self.object)
4642
return redirect(

src/webview/suggestions/views/lists.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def get_queryset(self) -> QuerySet[CVEDerivationClusterProposal]:
4545
)
4646
except ValueError:
4747
raise Http404
48-
query_filters = Q(cached__isnull=False)
48+
query_filters = Q()
4949
if self.status_filter is not None:
5050
query_filters &= Q(status=self.status_filter)
5151
if self.package_filter is not None:

src/webview/tests/test_suggestions_cached_race.py

Lines changed: 0 additions & 54 deletions
This file was deleted.

0 commit comments

Comments
 (0)