Problem Statement
I noticed that the ValidateRecord function calls the schema server:
|
resp, err := v.httpClient.Do(req) |
My issue with this is now our tests in dir depend on the schema server because of this
Proposed Solution
I understand it's easier to implement it this way because there's less duplication. But would it be possible to implement the validation in the code instead?
Alternatives Considered
No response
Additional Context
I'm not saying this is a huge issue, but I think validation should be done without calling any external services. I was surprised to learn that's not the case
Checklist
Problem Statement
I noticed that the
ValidateRecordfunction calls the schema server:oasf-sdk/pkg/validator/validation.go
Line 100 in e1739b7
My issue with this is now our tests in dir depend on the schema server because of this
Proposed Solution
I understand it's easier to implement it this way because there's less duplication. But would it be possible to implement the validation in the code instead?
Alternatives Considered
No response
Additional Context
I'm not saying this is a huge issue, but I think validation should be done without calling any external services. I was surprised to learn that's not the case
Checklist