Skip to content

Commit 05f627b

Browse files
authored
fix #103 #102 … (#104)
* specify StartRecordName, StartRecordType for displaying next page of ListResourceRecordSets * refactoring the listResourceRecordSets function to use the ListResourceRecordSetsPaginator * rename
1 parent af15cf2 commit 05f627b

1 file changed

Lines changed: 4 additions & 10 deletions

File tree

collector/aws/collector/route53/resourcerecordset.go.go renamed to collector/aws/collector/route53/resourcerecordset.go

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -85,19 +85,13 @@ func describeDomainRRDetails(ctx context.Context, c *route53.Client) (domainRRDe
8585
}
8686

8787
func listResourceRecordSets(ctx context.Context, c *route53.Client, hostZone types.HostedZone) (resourceRecordSets []types.ResourceRecordSet) {
88-
8988
input := &route53.ListResourceRecordSetsInput{
9089
HostedZoneId: hostZone.Id,
9190
}
92-
output, err := c.ListResourceRecordSets(ctx, input)
93-
if err != nil {
94-
log.CtxLogger(ctx).Warn("listResourceRecordSets error", zap.Error(err))
95-
return nil
96-
}
97-
resourceRecordSets = append(resourceRecordSets, output.ResourceRecordSets...)
98-
for output.IsTruncated {
99-
input.StartRecordIdentifier = output.NextRecordIdentifier
100-
output, err = c.ListResourceRecordSets(ctx, input)
91+
paginator := route53.NewListResourceRecordSetsPaginator(c, input)
92+
93+
for paginator.HasMorePages() {
94+
output, err := paginator.NextPage(ctx)
10195
if err != nil {
10296
log.CtxLogger(ctx).Warn("listResourceRecordSets error", zap.Error(err))
10397
return nil

0 commit comments

Comments
 (0)