Skip to content

Commit 1f01635

Browse files
SteNicholasFMX
authored andcommitted
[CELEBORN-1240][FOLLOWUP] Introduce web profile for web module
### What changes were proposed in this pull request? Introduce web profile for web module. ### Why are the changes needed? The compilation speed of web module is sometimes very slow due to the influence of the network, which hinders the development process. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes #2679 from SteNicholas/CELEBORN-1240. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com> (cherry picked from commit c0dda4a)
1 parent 139e47f commit 1f01635

2 files changed

Lines changed: 29 additions & 2 deletions

File tree

pom.xml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
<module>service</module>
3737
<module>master</module>
3838
<module>worker</module>
39-
<module>web</module>
4039
</modules>
4140

4241
<distributionManagement>
@@ -1634,6 +1633,13 @@
16341633
</modules>
16351634
</profile>
16361635

1636+
<profile>
1637+
<id>web</id>
1638+
<modules>
1639+
<module>web</module>
1640+
</modules>
1641+
</profile>
1642+
16371643
<profile>
16381644
<id>google-mirror</id>
16391645
<properties>

project/CelebornBuild.scala

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ object CelebornBuild extends sbt.internal.BuildDef {
336336
CelebornClient.client,
337337
CelebornService.service,
338338
CelebornWorker.worker,
339-
CelebornMaster.master) ++ maybeSparkClientModules ++ maybeFlinkClientModules ++ maybeMRClientModules
339+
CelebornMaster.master) ++ maybeSparkClientModules ++ maybeFlinkClientModules ++ maybeMRClientModules ++ maybeWebModules
340340
}
341341

342342
// ThisBuild / parallelExecution := false
@@ -401,6 +401,15 @@ object Utils {
401401

402402
lazy val maybeMRClientModules: Seq[Project] = mrClientProjects.map(_.modules).getOrElse(Seq.empty)
403403

404+
val WEB_VERSION = profiles.filter(_.startsWith("web")).headOption
405+
406+
lazy val webProjects = WEB_VERSION match {
407+
case Some("web") => Some(WebProjects)
408+
case _ => None
409+
}
410+
411+
lazy val maybeWebModules: Seq[Project] = webProjects.map(_.modules).getOrElse(Seq.empty)
412+
404413
def defaultScalaVersion(): String = {
405414
// 1. Inherit the scala version of the spark project
406415
// 2. if the spark profile not specified, using the DEFAULT_SCALA_VERSION
@@ -1236,3 +1245,15 @@ object MRClientProjects {
12361245
}
12371246
)
12381247
}
1248+
1249+
object WebProjects {
1250+
1251+
def web: Project = {
1252+
Project("celeborn-web", file("web"))
1253+
.settings(commonSettings)
1254+
}
1255+
1256+
def modules: Seq[Project] = {
1257+
Seq(web)
1258+
}
1259+
}

0 commit comments

Comments
 (0)