Skip to content

Commit 5be493b

Browse files
committed
Remove GroupBy.field_name from BanyanDB MeasureQuery request building
1 parent 9aac830 commit 5be493b

File tree

2 files changed

+1
-1
lines changed
  • docs/en/changes
  • oap-server/server-library/library-banyandb-client/src/main/java/org/apache/skywalking/library/banyandb/v1/client

2 files changed

+1
-1
lines changed

docs/en/changes/changes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
* Add Zipkin Virtual GenAI e2e test. Use `zipkin_json` exporter to avoid protobuf dependency conflict
77
between `opentelemetry-exporter-zipkin-proto-http` (protobuf~=3.12) and `opentelemetry-proto` (protobuf>=5.0).
88
* Fix missing `taskId` filter and incorrect `IN` clause parameter binding in `JDBCJFRDataQueryDAO` and `JDBCPprofDataQueryDAO`.
9+
* Remove deprecated `GroupBy.field_name` from BanyanDB `MeasureQuery` request building (Phase 1 of staged removal across repos).
910

1011
#### UI
1112

oap-server/server-library/library-banyandb-client/src/main/java/org/apache/skywalking/library/banyandb/v1/client/MeasureQuery.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ BanyandbMeasure.QueryRequest build() throws BanyanDBException {
182182
throw new IllegalArgumentException("field name cannot be null or empty if aggregation is specified");
183183
}
184184
} else {
185-
groupByBuilder.setFieldName(this.aggregation.fieldName);
186185
BanyandbMeasure.QueryRequest.Aggregation aggr = BanyandbMeasure.QueryRequest.Aggregation.newBuilder()
187186
.setFunction(this.aggregation.aggregationType.function)
188187
.setFieldName(this.aggregation.fieldName)

0 commit comments

Comments
 (0)