Skip to content

Commit 04436bd

Browse files
fix(ci): add ty check to parameters folder (#8035)
1 parent 7929795 commit 04436bd

File tree

5 files changed

+965
-806
lines changed

5 files changed

+965
-806
lines changed

aws_lambda_powertools/utilities/parameters/appconfig.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ def get_app_config(
162162
force_fetch: bool = False,
163163
max_age: int | None = None,
164164
**sdk_options,
165-
) -> str | bytes | list | dict:
165+
) -> str | bytes | list | dict | None:
166166
"""
167167
Retrieve a configuration value from AWS App Config.
168168

aws_lambda_powertools/utilities/parameters/secrets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ def get_secret(
459459
force_fetch: bool = False,
460460
max_age: int | None = None,
461461
**sdk_options,
462-
) -> str | bytes | dict:
462+
) -> str | bytes | dict | None:
463463
"""
464464
Retrieve a parameter value from AWS Secrets Manager
465465

aws_lambda_powertools/utilities/parameters/ssm.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -786,7 +786,7 @@ def get_parameter(
786786
force_fetch: bool = False,
787787
max_age: int | None = None,
788788
**sdk_options,
789-
) -> str | bytes | dict:
789+
) -> str | bytes | dict | None:
790790
"""
791791
Retrieve a parameter value from AWS Systems Manager (SSM) Parameter Store
792792
@@ -1060,14 +1060,16 @@ def set_parameter(
10601060
if "ssm" not in DEFAULT_PROVIDERS:
10611061
DEFAULT_PROVIDERS["ssm"] = SSMProvider()
10621062

1063-
return DEFAULT_PROVIDERS["ssm"].set(
1063+
provider: SSMProvider = DEFAULT_PROVIDERS["ssm"]
1064+
1065+
return provider.set( # ty: ignore[no-matching-overload]
10641066
name,
10651067
value,
1066-
parameter_type=parameter_type,
1068+
parameter_type=parameter_type, # type: ignore[arg-type]
10671069
overwrite=overwrite,
10681070
tier=tier,
10691071
description=description,
1070-
kms_key_id=kms_key_id,
1072+
kms_key_id=kms_key_id, # type: ignore[arg-type]
10711073
**sdk_options,
10721074
)
10731075

poetry.lock

Lines changed: 953 additions & 798 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ mkdocs-llmstxt = ">=0.2,<0.5"
129129
avro = "^1.12.0"
130130
protobuf = "^6.30.2"
131131
types-protobuf = "^6.30.2.20250516"
132-
ty = "^0.0.10"
132+
ty = "^0.0.23"
133133

134134
[tool.coverage.run]
135135
source = ["aws_lambda_powertools"]
@@ -219,6 +219,9 @@ replace = 'VERSION = "{new_version}"'
219219

220220
[tool.ty]
221221
# ty type checker configuration
222+
# Ignore unused type: ignore comments since we also run mypy which may need them
223+
[tool.ty.rules]
224+
unused-type-ignore-comment = "ignore"
222225

223226
[tool.ty.src]
224227
include = ["aws_lambda_powertools/**"]
@@ -234,7 +237,6 @@ exclude = [
234237
"aws_lambda_powertools/metrics/**",
235238
"aws_lambda_powertools/middleware_factory/**",
236239
"aws_lambda_powertools/utilities/streaming/**",
237-
"aws_lambda_powertools/utilities/parameters/**",
238240
"aws_lambda_powertools/utilities/parser/**",
239241
"aws_lambda_powertools/utilities/data_masking/**",
240242
"aws_lambda_powertools/tracing/**",

0 commit comments

Comments
 (0)