Skip to content

Commit 2c1c880

Browse files
authored
Add spec.revisionHistoryLimit config possibility for Deployment resource (#122)
* Add spec.revisionHistoryLimit config possibility for Deployment resource Signed-off-by: Marcel Hoyer <mhoyer@pixelplastic.de> * Fix order of values in README.md Signed-off-by: Marcel Hoyer <mhoyer@pixelplastic.de> --------- Signed-off-by: Marcel Hoyer <mhoyer@pixelplastic.de>
1 parent 111933e commit 2c1c880

File tree

5 files changed

+14
-2
lines changed

5 files changed

+14
-2
lines changed

charts/backstage/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,4 @@ sources:
3838
# This is the chart version. This version number should be incremented each time you make changes
3939
# to the chart and its templates, including the app version.
4040
# Versions are expected to follow Semantic Versioning (https://semver.org/)
41-
version: 1.1.3
41+
version: 1.2.0

charts/backstage/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Backstage Helm Chart
33

44
[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/backstage)](https://artifacthub.io/packages/search?repo=backstage)
5-
![Version: 1.1.3](https://img.shields.io/badge/Version-1.1.3-informational?style=flat-square)
5+
![Version: 1.2.0](https://img.shields.io/badge/Version-1.2.0-informational?style=flat-square)
66
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
77

88
A Helm chart for deploying a Backstage application
@@ -142,6 +142,7 @@ Kubernetes: `>= 1.19.0-0`
142142
| backstage.readinessProbe | Readiness Probe Backstage doesn't provide any health endpoints by default. A simple one can be added like this: https://backstage.io/docs/plugins/observability/#health-checks <br /> Ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes <!-- E.g. readinessProbe: failureThreshold: 3 httpGet: path: /healthcheck port: 7007 scheme: HTTP initialDelaySeconds: 30 periodSeconds: 10 successThreshold: 2 timeoutSeconds: 2 | object | `{}` |
143143
| backstage.replicas | Number of deployment replicas | int | `1` |
144144
| backstage.resources | Resource requests/limits <br /> Ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#resource-requests-and-limits-of-pod-and-container <!-- E.g. resources: limits: memory: 1Gi cpu: 1000m requests: memory: 250Mi cpu: 100m --> | object | `{}` |
145+
| backstage.revisionHistoryLimit | Define the [count of deployment revisions](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy) to be kept. May be set to 0 in case of GitOps deployment approach. | int | `10` |
145146
| backstage.tolerations | Node tolerations for server scheduling to nodes with taints <br /> Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ | list | `[]` |
146147
| clusterDomain | Default Kubernetes cluster domain | string | `"cluster.local"` |
147148
| commonAnnotations | Annotations to add to all deployed objects | object | `{}` |

charts/backstage/templates/backstage-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ metadata:
2121
{{- end }}
2222
spec:
2323
replicas: {{ .Values.backstage.replicas }}
24+
revisionHistoryLimit: {{ .Values.backstage.revisionHistoryLimit }}
2425
selector:
2526
matchLabels: {{- include "common.labels.matchLabels" . | nindent 6 }}
2627
app.kubernetes.io/component: backstage

charts/backstage/values.schema.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,12 @@
174174
"minimum": 0,
175175
"default": 1
176176
},
177+
"revisionHistoryLimit": {
178+
"title": "The count of deployment revisions",
179+
"type": "integer",
180+
"minimum": 0,
181+
"default": 10
182+
},
177183
"image": {
178184
"title": "Image parameters",
179185
"type": "object",

charts/backstage/values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ backstage:
8383
# -- Number of deployment replicas
8484
replicas: 1
8585

86+
# -- Define the [count of deployment revisions](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy) to be kept.
87+
# May be set to 0 in case of GitOps deployment approach.
88+
revisionHistoryLimit: 10
89+
8690
image:
8791

8892
# -- Backstage image registry

0 commit comments

Comments
 (0)