bugfix: Render globally configured image pull secrets in deployment template (#64)

Co-authored-by: Max Nitze <Max.Nitze@mgm-tp.com>

Author: maxnitze

charts/backstage/Chart.yaml

@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.17.0
+version: 0.17.1
 
 dependencies:
   - name: common

charts/backstage/README.md

@@ -1,7 +1,7 @@
 
 # Backstage Helm Chart
 
-![Version: 0.17.0](https://img.shields.io/badge/Version-0.17.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
+![Version: 0.17.1](https://img.shields.io/badge/Version-0.17.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
 
 A Helm chart for deploying a Backstage application
 

charts/backstage/templates/_helpers.tpl

@@ -5,6 +5,13 @@ Return the proper image name
 {{ include "common.images.image" (dict "imageRoot" .Values.backstage.image "global" .Values.global) }}
 {{- end -}}
 
+{{/*
+Return the proper Docker Image Registry Secret Names
+*/}}
+{{- define "backstage.renderImagePullSecrets" -}}
+{{- include "common.images.renderPullSecrets" (dict "images" (list .Values.backstage.image) "context" $) -}}
+{{- end -}}
+
 {{/*
  Create the name of the service account to use
  */}}

charts/backstage/templates/backstage-deployment.yaml

@@ -56,12 +56,7 @@ spec:
           configMap:
             name: backstage-app-config
         {{- end }}
-      {{- if .Values.backstage.image.pullSecrets }}
-      imagePullSecrets:
-      {{- range .Values.backstage.image.pullSecrets }}
-          - name: {{ . }}
-      {{- end }}
-      {{- end }}
+      {{- include "backstage.renderImagePullSecrets" . | nindent 6 }}
       {{- if .Values.backstage.initContainers }}
       initContainers:
         {{- include "common.tplvalues.render" ( dict "value" .Values.backstage.initContainers "context" $) | nindent 8 }}