Skip to content

Commit 965b79a

Browse files
authored
Fix issues with resources and args (#34)
1 parent 8f188f5 commit 965b79a

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

charts/backstage/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ type: application
1515
# This is the chart version. This version number should be incremented each time you make changes
1616
# to the chart and its templates, including the app version.
1717
# Versions are expected to follow Semantic Versioning (https://semver.org/)
18-
version: 0.15.2
18+
version: 0.16.0
1919

2020
dependencies:
2121
- name: common

charts/backstage/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
# Backstage Helm Chart
33

4-
![Version: 0.15.2](https://img.shields.io/badge/Version-0.15.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
4+
![Version: 0.16.0](https://img.shields.io/badge/Version-0.16.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
55

66
A Helm chart for deploying a Backstage application
77

@@ -104,6 +104,7 @@ The command removes all the Kubernetes components associated with the chart and
104104
| backstage.image.repository | Backstage image repository | string | `"backstage/backstage"` |
105105
| backstage.image.tag | Backstage image tag (immutable tags are recommended) | string | `"latest"` |
106106
| backstage.initContainers | Backstage container init containers | list | `[]` |
107+
| backstage.installDir | Directory containing the backstage installation | string | `"/app"` |
107108
| backstage.podAnnotations | Annotations to add to the backend deployment pods | object | `{}` |
108109
| backstage.podSecurityContext | Security settings for a Pod. The security settings that you specify for a Pod apply to all Containers in the Pod. <br /> Ref: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#set-the-security-context-for-a-pod | object | `{}` |
109110
| backstage.resources | Resource requests/limits <br /> Ref: https://kubernetes.io/docs/user-guide/compute-resources/ <!-- E.g. resources: limits: memory: 1Gi cpu: 1000m requests: memory: 250Mi cpu: 100m --> | object | `{}` |

charts/backstage/templates/backstage-deployment.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{{- $imageRepository := .Values.backstage.image.repository | required "The repository name of the image is required (e.g. my-backstage:tag | docker.io/my-backstage:tag) !" -}}
22
{{- $imageTag := .Values.backstage.image.tag | required "The image tag is required (e.g my-backstage:tag | docker.io/my-backstage:tag) !" -}}
3+
{{- $installDir := .Values.backstage.installDir -}}
34
---
45
apiVersion: {{ include "common.capabilities.deployment.apiVersion" . }}
56
kind: Deployment
@@ -89,12 +90,12 @@ spec:
8990
{{- if .Values.backstage.extraAppConfig }}
9091
{{- range .Values.backstage.extraAppConfig }}
9192
- "--config"
92-
- {{ .filename | quote }}
93+
- "{{ $installDir }}/{{ .filename }}"
9394
{{- end }}
9495
{{- end }}
9596
{{- if .Values.backstage.appConfig }}
9697
- "--config"
97-
- "app-config-from-configmap.yaml"
98+
- "{{ $installDir }}/app-config-from-configmap.yaml"
9899
{{- end }}
99100
{{- end }}
100101
{{- if .Values.backstage.resources }}
@@ -134,12 +135,12 @@ spec:
134135
volumeMounts:
135136
{{- range .Values.backstage.extraAppConfig }}
136137
- name: {{ .configMapRef }}
137-
mountPath: "/app/{{ .filename }}"
138+
mountPath: "{{ $installDir }}/{{ .filename }}"
138139
subPath: {{ .filename }}
139140
{{- end }}
140141
{{- if .Values.backstage.appConfig }}
141142
- name: backstage-app-config
142-
mountPath: /app/app-config-from-configmap.yaml
143+
mountPath: "{{ $installDir }}/app-config-from-configmap.yaml"
143144
subPath: app-config.yaml
144145
{{- end }}
145146
{{- if .Values.backstage.extraVolumeMounts }}

charts/backstage/values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,9 @@ backstage:
135135
# -- Backstage container init containers
136136
initContainers: []
137137

138+
# -- Directory containing the backstage installation
139+
installDir: /app
140+
138141
# -- Resource requests/limits
139142
# <br /> Ref: https://kubernetes.io/docs/user-guide/compute-resources/
140143
# <!-- E.g.

0 commit comments

Comments
 (0)