replace mapfile with __split

`mapfile` doesn't exist on bash v3, and doesn't support `-d` until v4.4, furthermore it doesn't support multiple delimiters, multi-length delimiter(s), trimming zero-length, nor easy append

also deprecated `get-array` with new `__make_array`

fix some bad `--=` usage

Author: balupton

commands.beta/echo-revolving-screen

@@ -42,7 +42,7 @@ function echo_revolving_screen() (
 	# determine columns
 	if [[ -z $option_lines || -z $option_columns ]]; then
 		local terminal_size=()
-		mapfile -t terminal_size < <(get-terminal-lines-and-columns || :)
+		__split terminal_size --no-zero-length < <(get-terminal-lines-and-columns || :)
 		if [[ ${#terminal_size[@]} -eq 2 ]]; then
 			if [[ -z $option_lines ]]; then
 				option_lines="${terminal_size[0]}"

commands.beta/macos-settings

@@ -53,7 +53,7 @@ function macos_settings() (
 
 	# ask
 	local choices=()
-	mapfile -t choices < <(
+	__split choices --no-zero-length < <(
 		choose --linger --confirm --multi \
 			--question="Which settings would you like to enable" \
 			--label -- \

commands.beta/wallhaven-helper

@@ -59,7 +59,7 @@ function wallhaven_helper() (
 
 	# collections
 	local collections collection
-	mapfile -t collections < <(fetch "https://wallhaven.cc/api/v1/collections?apikey=$apikey" | jq -r '.data[] | (.id, .label)')
+	__split collections --no-zero-length < <(fetch "https://wallhaven.cc/api/v1/collections?apikey=$apikey" | jq -r '.data[] | (.id, .label)')
 	collection="$(
 		choose \
 			--question='Which collection to download?' \

commands/get-array commands.deprecated/get-arraycommands/get-array renamed to commands.deprecated/get-array

@@ -2,6 +2,7 @@
 
 function get_array() (
 	source "$DOROTHY/sources/bash.bash"
+	dorothy-warnings add --code='get-array' --bold=' has been deprecated in favor of ' --code='__make_array'
 
 	# =====================================
 	# Arguments
@@ -19,7 +20,7 @@ function get_array() (
 			    How many items to output.
 
 			EXAMPLE:
-			mapfile -t arr < <(get-array 10)
+			__split arr --no-zero-length < <(get-array 10)
 		EOF
 		if [[ $# -ne 0 ]]; then
 			echo-error "$@"
@@ -57,10 +58,11 @@ function get_array() (
 	# =====================================
 	# Action
 
-	local i
+	local i lines=''
 	for ((i = 0; i < option_size; i++)); do
-		__print_line
+		lines+=$'\n'
 	done
+	__print_string "$lines"
 )
 
 # fire if invoked standalone

commands/checksum

@@ -69,7 +69,7 @@ function checksum_() (
 			;;
 		'--algorithm='*) option_algorithm="${item#*=}" ;;
 		'--')
-			mapfile -t option_paths < <(fs-absolute -- "$@")
+			__split option_paths --no-zero-length < <(fs-absolute -- "$@")
 			shift $#
 			break
 			;;

commands/choose

@@ -738,13 +738,11 @@ function choose_() (
 		'--match='*) option_matches+=("${item#*=}") ;;
 		'--default-exact='* | '--default='*) defaults_exact+=("${item#*=}") ;;
 		'--defaults-exact='* | '--defaults='*)
-			mapfile -t tmp <<<"${item#*=}"
-			defaults_exact+=("${tmp[@]}")
+			__split defaults_exact --append -- "${item#*=}"
 			;;
 		'--default-fuzzy='*) defaults_fuzzy+=("${item#*=}") ;;
 		'--defaults-fuzzy='*)
-			mapfile -t tmp <<<"${item#*=}"
-			defaults_fuzzy+=("${tmp[@]}")
+			__split defaults_fuzzy --append -- "${item#*=}"
 			;;
 		'--no-default-all'* | '--default-all'*)
 			option_default_all="$(get-flag-value --affirmative --fallback="$option_default_all" -- "$item")"
@@ -1249,8 +1247,7 @@ function choose_() (
 		style__hide_cursor=''
 		style__show_cursor=''
 		# set rendering
-		mapfile -t items_renders < <(get-array "$items_count")
-		mapfile -t items_rows < <(get-array "$items_count")
+		__make_array items_renders items_rows --size="$items_count"
 		# paging support is eternal, so no need for future updates if disabled
 		function reset_terminal_modifications_now {
 			:
@@ -1275,7 +1272,7 @@ function choose_() (
 		function refresh_terminal_size {
 			# refresh
 			local terminal_size=()
-			mapfile -t terminal_size < <(get-terminal-lines-and-columns)
+			__split terminal_size --no-zero-length < <(get-terminal-lines-and-columns)
 			terminal_lines="${terminal_size[0]}"
 			terminal_columns="${terminal_size[1]}"
 
@@ -1308,8 +1305,7 @@ function choose_() (
 
 				# reset paging for new size
 				paging_used='maybe'
-				mapfile -t items_renders < <(get-array "$items_count")
-				mapfile -t items_rows < <(get-array "$items_count")
+				__make_array items_renders items_rows --size="$items_count"
 
 				# update priors
 				terminal_lines_prior="$terminal_lines"
@@ -2234,7 +2230,7 @@ function choose_() (
 			# input => keys => key
 			keys=()
 			skips=()
-			mapfile -t keys <<<"$input"
+			__split keys -- "$input"
 			for key in "${keys[@]}"; do
 				if is-digit -- "$key"; then
 					action_jump "$key"

commands/choose-path

@@ -43,7 +43,7 @@ function choose_path() (
 
 	# adjust args to paths and basenames
 	local values=()
-	mapfile -t values < <(echo-paths-and-basenames -- "${option_paths[@]}")
+	__split values --no-zero-length < <(echo-paths-and-basenames -- "${option_paths[@]}")
 
 	# ask with label
 	choose --label "${options[@]}" -- "${values[@]}"

commands/config-helper

@@ -361,7 +361,7 @@ function config_helper() (
 				fi
 
 				# adapt for array
-				mapfile -t lines <<<"$value" # read lines into an array, such that indentation works
+				__split lines --keep-zero-length -- "$value" # read lines into an array, such that indentation works
 
 				# addition, use spaces for consistency with replacements, also use spaces as editors show tabs at variable widths
 				value=$'(\n'"$(echo-lines --indent=$'\t' --quote="$option_quote" --columns="${option_columns:-"1"}" --width=inputs --filler=space -- "${lines[@]}")"$'\n)'

commands/confirm

@@ -336,7 +336,7 @@ function confirm_() (
 
 		# input => keys => key
 		keys=()
-		mapfile -t keys <<<"$input"
+		__split keys -- "$input"
 
 		# prep clearing of any input that leaked
 		question_confirm_and_input_lines=''

commands/debug-bash

@@ -54,7 +54,7 @@ function debug_bash() (
 		'--versions='*)
 			item="${item#*=}"
 			if [[ -n $item ]]; then
-				mapfile -t option_bash_binaries <<<"${item#*=}"
+				__split option_bash_binaries --no-zero-length -- "${item#*=}"
 			fi
 			;;
 		'--bash='* | '--version='*) option_bash_binaries+=("${item#*=}") ;;
@@ -63,7 +63,7 @@ function debug_bash() (
 				continue
 			fi
 			local bash_binaries=()
-			mapfile -t bash_binaries < <(
+			__split bash_binaries --no-zero-length < <(
 				type -pa bash
 				expand-path -- "$XDG_BIN_HOME/bash-*"
 			)