Skip to content

Commit d6492d8

Browse files
committed
eval-tester: change element output to be intuitive for inlines
elements are now inline, which creates intuitive output for exact mode - `expected` output now called `expect` for alignment with `actual` this made it easier to fix `read-key` tests for exactness
1 parent e84aab5 commit d6492d8

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

commands/eval-tester

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ function eval_tester() (
407407
function __element {
408408
local label="$1" style="$2" value="$3"
409409
if [[ -n $value ]]; then
410-
__print_style --"$style"+element="$label" --newline --="$value" --newline --"$style"+/element="$label" || return 223 # ECUSTOM 223 Tests broken
410+
__print_style --"$style"+element="$label" --="$value" --"$style"+/element="$label" || return 223 # ECUSTOM 223 Tests broken
411411
else
412412
__print_style --"$style"+element/="$label" --commentary-empty || return 223 # ECUSTOM 223 Tests broken
413413
fi
@@ -416,7 +416,7 @@ function eval_tester() (
416416
local label="$1" style="$2" value="$3" escaped
417417
if [[ -n $value ]]; then
418418
printf -v escaped '%q' "$value" || return $?
419-
__element "$label escaped" "$style" "$escaped" || return $?
419+
__print_style --"$style"+element="$label escaped" --="$escaped" --"$style"+/element="$label escaped" || return 223 # ECUSTOM 223 Tests broken
420420
else
421421
__print_style --"$style"+element/="$label escaped" --commentary-empty || return 223 # ECUSTOM 223 Tests broken
422422
fi
@@ -461,11 +461,11 @@ function eval_tester() (
461461
__print_style --error="${name} is NOT EXPECTED" || return 223 # ECUSTOM 223 Tests broken
462462
if ! __is_shapeshifter -- "$actual$expected"; then
463463
__element "actual $name" red "$actual" || return $?
464-
__element "expected $name" red "$expected" || return $?
464+
__element "expect $name" red "$expected" || return $?
465465
fi
466466
if [[ $actual$expected =~ [[:cntrl:]] ]]; then
467467
__escaped_element "actual $name" red "$actual" || return $?
468-
__escaped_element "expected $name" red "$expected" || return $?
468+
__escaped_element "expect $name" red "$expected" || return $?
469469
fi
470470
local diff actual_file expected_file
471471
actual_file="$(fs-temp --directory='dorothy' --directory='eval-tester' --file)" || return 223 # ECUSTOM 223 Tests broken

commands/read-key

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,40 +75,40 @@ function read_key_test() (
7575

7676
{
7777
printf '%s' "$ANSI_ALL"
78-
} | eval-tester --name='all was detected' --stdout='all' -- \
78+
} | eval-tester --name='all was detected' --stdout=$'all\n' -- \
7979
read-key --timeout="$delay"
8080

8181
eval-tester --name='timeout was detected' --status='60' -- \
8282
read-key --timeout="$delay"
8383

8484
{
8585
__print_line
86-
} | eval-tester --name='enter was detected' --stdout='enter' -- \
86+
} | eval-tester --name='enter was detected' --stdout=$'enter\n' -- \
8787
read-key --timeout="$delay"
8888

8989
{
9090
printf '%s' $'\x0a'
91-
} | eval-tester --name='enter was detected' --stdout='enter' -- \
91+
} | eval-tester --name='enter was detected' --stdout=$'enter\n' -- \
9292
read-key --timeout="$delay"
9393

9494
{
9595
printf '%s' $'\e\e\e\e'
96-
} | eval-tester --name='escapes were detected' --stdout=$'escape\nescape\nescape\nescape' -- \
96+
} | eval-tester --name='escapes were detected' --stdout=$'escape\nescape\nescape\nescape\n' -- \
9797
read-key --timeout="$delay"
9898

9999
{
100100
printf '%s' $'\e[Ha\e[1~'
101-
} | eval-tester --name='home variants were detected' --stdout=$'home\na\nhome' -- \
101+
} | eval-tester --name='home variants were detected' --stdout=$'home\na\nhome\n' -- \
102102
read-key --timeout="$delay"
103103

104104
{
105105
printf '%s' $'\e[B'
106-
} | eval-tester --name='down was detected' --stdout='down' -- \
106+
} | eval-tester --name='down was detected' --stdout=$'down\n' -- \
107107
read-key --timeout="$delay"
108108

109109
{
110110
printf '%s' $'\e[F'
111-
} | eval-tester --name='end was detected' --stdout='end' -- \
111+
} | eval-tester --name='end was detected' --stdout=$'end\n' -- \
112112
read-key --timeout="$delay"
113113

114114
local enter_if_not_ignored
@@ -119,17 +119,17 @@ function read_key_test() (
119119
fi
120120
{
121121
printf '%s' $'\e\e\n\e[Hab\e[1~cd'
122-
} | eval-tester --name='a series of characters were detected' --stdout=$'escape\nescape\n'"$enter_if_not_ignored"$'home\na\nb\nhome\nc\nd' -- \
122+
} | eval-tester --name='a series of characters were detected' --stdout=$'escape\nescape\n'"$enter_if_not_ignored"$'home\na\nb\nhome\nc\nd\n' -- \
123123
read-key --timeout="$delay"
124124

125125
{
126126
printf '%s' $'\e[Hab\e[1~cd\e[F\e[Jef'
127-
} | eval-tester --name='unknown read-key ANSI escape codes report failure' --status=94 --stdout=$'home\na\nb\nhome\nc\nd\nend' -- \
127+
} | eval-tester --name='unknown read-key ANSI escape codes report failure' --status=94 --stdout=$'home\na\nb\nhome\nc\nd\nend\n' -- \
128128
read-key --timeout="$delay"
129129

130130
{
131131
printf '%s' $'\e[Hab\e[1~cd\e[F\e[Jef'
132-
} | eval-tester --name='unknown read-key ANSI escape codes report verbal failure if verbose' --status=94 --stdout=$'home $\'\\E[H\'\na a\nb b\nhome $\'\\E[1~\'\nc c\nd d\nend $\'\\E[F\'' --stderr="unknown \$'\E[Jef'" -- \
132+
} | eval-tester --name='unknown read-key ANSI escape codes report verbal failure if verbose' --status=94 --stdout=$'home $\'\\E[H\'\na a\nb b\nhome $\'\\E[1~\'\nc c\nd d\nend $\'\\E[F\'\n' --stderr=$'unknown $\'\\E[Jef\'\n' -- \
133133
read-key --verbose --timeout="$delay"
134134

135135
return 0

0 commit comments

Comments
 (0)