-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feature-gated System::refresh_hotpatch with no default impl is inconvenient for crate authors #23653
Copy link
Copy link
Open
Labels
A-Dev-ToolsTools used to debug Bevy applications.Tools used to debug Bevy applications.A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorAn unexpected or incorrect behaviorD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-ContentiousThere are nontrivial implications that should be thought throughThere are nontrivial implications that should be thought through
Metadata
Metadata
Assignees
Labels
A-Dev-ToolsTools used to debug Bevy applications.Tools used to debug Bevy applications.A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorAn unexpected or incorrect behaviorD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-ContentiousThere are nontrivial implications that should be thought throughThere are nontrivial implications that should be thought through
Type
Projects
Status
Needs SME Triage
When the user uses the
hotpatchingfeature, theSystemtrait has one additional method,refresh_hotpatch.However, this method has no default impl. This means that other 3rd party crates the user relies on need to offer that feature too if these manually implement
System, even if hotpatching makes no sense for them. If they don't do this, the user's project wont compile.A solution could be to add an empty body as the default impl.