Skip to content

feature-gated System::refresh_hotpatch with no default impl is inconvenient for crate authors #23653

@urben1680

Description

@urben1680

When the user uses the hotpatching feature, the System trait has one additional method, refresh_hotpatch.

However, this method has no default impl. This means that other 3rd party crates the user relies on need to offer that feature too if these manually implement System, even if hotpatching makes no sense for them. If they don't do this, the user's project wont compile.

A solution could be to add an empty body as the default impl.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-Dev-ToolsTools used to debug Bevy applications.A-ECSEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!X-ContentiousThere are nontrivial implications that should be thought through

    Type

    No type

    Projects

    Status

    Needs SME Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions