fix lint warnings

Author: rsteube

.golangci.yml

@@ -0,0 +1,14 @@
+version: "2"
+linters:
+  exclusions:
+    paths:
+      - third_party
+  settings:
+    errcheck:
+      exclude-functions:
+        - fmt.Fprint
+        - fmt.Fprintf
+        - fmt.Fprintln
+        - (*os.File).Close
+        - os.RemoveAll
+        - os.Unsetenv

action.go

@@ -320,7 +320,7 @@ func (a Action) split(pipelines bool) Action {
 				case shlex.QUOTING_STATE:
 					invoked.action.rawValues[index].Value = fmt.Sprintf(`'%v'`, strings.ReplaceAll(value.Value, `'`, `'"'"'`))
 				default:
-					invoked.action.rawValues[index].Value = strings.Replace(value.Value, ` `, `\ `, -1)
+					invoked.action.rawValues[index].Value = strings.ReplaceAll(value.Value, ` `, `\ `)
 				}
 			}
 			if !invoked.action.meta.Nospace.Matches(value.Value) {

docs/book.toml

@@ -19,4 +19,4 @@ enable = true
 
 [output.linkcheck]
 follow-web-links = true
-exclude = [ 'gnu\.org', '\./.+/out/.+\.gif', 'go\.dev', 'microsoft\.com']
+exclude = [ 'gnu\.org', '\./.+/out/.+\.gif', 'go\.dev', 'microsoft\.com', 'iridakos\.com']

internal/common/message.go

@@ -126,7 +126,7 @@ func (m Messages) Integrate(values RawValues, prefix string) RawValues {
 }
 
 func (m Messages) MarshalJSON() ([]byte, error) {
-	var result []string = make([]string, 0, len(m.messages))
+	var result = make([]string, 0, len(m.messages))
 	for key := range m.messages {
 		result = append(result, key)
 	}

internal/config/config.go

@@ -95,7 +95,7 @@ func load(name string, c configMap) error {
 func GetStyleConfigs() []string                   { return config.Styles.Keys() }
 func GetStyleFields(name string) ([]Field, error) { return config.Styles.Fields(name) }
 func SetStyle(key, value string) error {
-	return set("styles", key, strings.Replace(value, ",", " ", -1))
+	return set("styles", key, strings.ReplaceAll(value, ",", " "))
 }
 
 func set(name, key, value string) error {

internal/shell/tcsh/action.go

@@ -74,7 +74,7 @@ func ActionRawValues(currentWord string, meta common.Meta, values common.RawValu
 	for _, r := range values {
 		// TODO optimize
 		if wordbreaks, ok := os.LookupEnv("COMP_WORDBREAKS"); ok {
-			wordbreaks = strings.Replace(wordbreaks, " ", "", -1)
+			wordbreaks = strings.ReplaceAll(wordbreaks, " ", "")
 			if index := strings.LastIndexAny(currentWord, wordbreaks); index != -1 {
 				r.Value = strings.TrimPrefix(r.Value, currentWord[:index+1])
 				lastSegment = currentWord[index+1:]
@@ -101,7 +101,7 @@ func ActionRawValues(currentWord string, meta common.Meta, values common.RawValu
 		} else {
 			if val.Description != "" {
 				// TODO seems actual value needs to be used or it won't be shown if the prefix doesn't match
-				vals[index] = fmt.Sprintf("%v_(%v)", quoter.Replace(sanitizer.Replace(val.Value)), quoter.Replace(strings.Replace(sanitizer.Replace(val.TrimmedDescription()), " ", "_", -1)))
+				vals[index] = fmt.Sprintf("%v_(%v)", quoter.Replace(sanitizer.Replace(val.Value)), quoter.Replace(strings.ReplaceAll(sanitizer.Replace(val.TrimmedDescription()), " ", "_")))
 			} else {
 				vals[index] = quoter.Replace(sanitizer.Replace(val.Value))
 			}

internal/shell/xonsh/snippet.go

@@ -11,7 +11,7 @@ import (
 
 // Snippet creates the xonsh completion script.
 func Snippet(cmd *cobra.Command) string {
-	functionName := strings.Replace(cmd.Name(), "-", "__", -1)
+	functionName := strings.ReplaceAll(cmd.Name(), "-", "__")
 	return fmt.Sprintf(`from xonsh.completers.completer import add_one_completer
 from xonsh.completers.tools import contextual_command_completer