fix lint warnings

Author: rsteube

.golangci.yml

@@ -0,0 +1,5 @@
+version: "2"
+linters:
+  exclusions:
+    paths:
+      - third_party

action.go

@@ -320,7 +320,7 @@ func (a Action) split(pipelines bool) Action {
 				case shlex.QUOTING_STATE:
 					invoked.action.rawValues[index].Value = fmt.Sprintf(`'%v'`, strings.ReplaceAll(value.Value, `'`, `'"'"'`))
 				default:
-					invoked.action.rawValues[index].Value = strings.Replace(value.Value, ` `, `\ `, -1)
+					invoked.action.rawValues[index].Value = strings.ReplaceAll(value.Value, ` `, `\ `)
 				}
 			}
 			if !invoked.action.meta.Nospace.Matches(value.Value) {

action_test.go

@@ -15,7 +15,7 @@ import (
 )
 
 func init() {
-	os.Unsetenv("LS_COLORS")
+	_ = os.Unsetenv("LS_COLORS")
 }
 
 func assertEqual(t *testing.T, expected, actual InvokedAction) {

carapace_test.go

@@ -12,7 +12,7 @@ import (
 )
 
 func init() {
-	os.Unsetenv("LS_COLORS")
+	_ = os.Unsetenv("LS_COLORS")
 }
 
 func execCompletion(args ...string) (context Context) {
@@ -58,7 +58,7 @@ func execCompletion(args ...string) (context Context) {
 func testContext(t *testing.T, expected Context, args ...string) {
 	t.Run(strings.Join(args, " "), func(t *testing.T) {
 		null, _ := os.Open(os.DevNull)
-		defer null.Close()
+		defer null.Close() // nolint:errcheck
 
 		sOut := os.Stdout
 		sErr := os.Stderr

command.go

@@ -40,9 +40,9 @@ func addCompletionCommand(targetCmd *cobra.Command) {
 			}
 
 			if s, err := complete(parentCmd, args); err != nil {
-				fmt.Fprintln(io.MultiWriter(parentCmd.OutOrStderr(), LOG.Writer()), err.Error())
+				fmt.Fprintln(io.MultiWriter(parentCmd.OutOrStderr(), LOG.Writer()), err.Error()) // nolint:errcheck
 			} else {
-				fmt.Fprintln(io.MultiWriter(parentCmd.OutOrStdout(), LOG.Writer()), s)
+				fmt.Fprintln(io.MultiWriter(parentCmd.OutOrStdout(), LOG.Writer()), s) // nolint:errcheck
 			}
 		},
 		FParseErrWhitelist: cobra.FParseErrWhitelist{
@@ -93,7 +93,7 @@ func addCompletionCommand(targetCmd *cobra.Command) {
 	specCmd := &cobra.Command{
 		Use: "spec",
 		Run: func(cmd *cobra.Command, args []string) {
-			fmt.Fprint(cmd.OutOrStdout(), spec.Spec(targetCmd))
+			fmt.Fprint(cmd.OutOrStdout(), spec.Spec(targetCmd)) // nolint:errcheck
 		},
 	}
 	carapaceCmd.AddCommand(specCmd)
@@ -112,10 +112,10 @@ func addCompletionCommand(targetCmd *cobra.Command) {
 			for _, arg := range args {
 				if splitted := strings.SplitN(arg, "=", 2); len(splitted) == 2 {
 					if err := style.Set(splitted[0], splitted[1]); err != nil {
-						fmt.Fprint(cmd.ErrOrStderr(), err.Error())
+						fmt.Fprint(cmd.ErrOrStderr(), err.Error()) // nolint:errcheck
 					}
 				} else {
-					fmt.Fprintf(cmd.ErrOrStderr(), "invalid format: '%v'", arg)
+					fmt.Fprintf(cmd.ErrOrStderr(), "invalid format: '%v'", arg) // nolint:errcheck
 				}
 			}
 		},

compat_test.go

@@ -53,7 +53,7 @@ func TestRegisterFlagCompletion(t *testing.T) {
 	os.Args = []string{"", "__complete", "--flag", ""}
 	_ = cmd.Execute()
 
-	w.Close()
+	_ = w.Close()
 	out, _ := io.ReadAll(r)
 	os.Stdout = rescueStdout
 

example/cmd/interspersed.go

@@ -11,7 +11,7 @@ var interspersedCmd = &cobra.Command{
 	Use:   "interspersed",
 	Short: "interspersed example",
 	Run: func(cmd *cobra.Command, args []string) {
-		fmt.Fprintf(cmd.OutOrStdout(), "#%v", args)
+		fmt.Fprintf(cmd.OutOrStdout(), "#%v", args) // nolint:errcheck
 	},
 }
 

example/cmd/modifier_test.go

@@ -101,7 +101,7 @@ func TestChdir(t *testing.T) {
 }
 
 func TestChdirF(t *testing.T) {
-	os.Unsetenv("LS_COLORS")
+	_ = os.Unsetenv("LS_COLORS")
 	sandbox.Package(t, "github.com/carapace-sh/carapace/example")(func(s *sandbox.Sandbox) {
 		s.Files(
 			".git/config", "",
@@ -159,7 +159,7 @@ func TestMultiParts(t *testing.T) {
 }
 
 func TestPrefix(t *testing.T) {
-	os.Unsetenv("LS_COLORS")
+	_ = os.Unsetenv("LS_COLORS")
 	sandbox.Package(t, "github.com/carapace-sh/carapace/example")(func(s *sandbox.Sandbox) {
 		s.Files("subdir/file1.txt", "")
 
@@ -294,7 +294,7 @@ func TestMultiPartsP(t *testing.T) {
 }
 
 func TestSplit(t *testing.T) {
-	os.Unsetenv("LS_COLORS")
+	_ = os.Unsetenv("LS_COLORS")
 	sandbox.Package(t, "github.com/carapace-sh/carapace/example")(func(s *sandbox.Sandbox) {
 		s.Files("subdir/file1.txt", "")
 
@@ -376,7 +376,7 @@ func TestSplit(t *testing.T) {
 }
 
 func TestSplitP(t *testing.T) {
-	os.Unsetenv("LS_COLORS")
+	_ = os.Unsetenv("LS_COLORS")
 	sandbox.Package(t, "github.com/carapace-sh/carapace/example")(func(s *sandbox.Sandbox) {
 		s.Files("subdir/file1.txt", "")
 

internal/common/message.go

@@ -126,7 +126,7 @@ func (m Messages) Integrate(values RawValues, prefix string) RawValues {
 }
 
 func (m Messages) MarshalJSON() ([]byte, error) {
-	var result []string = make([]string, 0, len(m.messages))
+	var result = make([]string, 0, len(m.messages))
 	for key := range m.messages {
 		result = append(result, key)
 	}

internal/config/config.go

@@ -95,7 +95,7 @@ func load(name string, c configMap) error {
 func GetStyleConfigs() []string                   { return config.Styles.Keys() }
 func GetStyleFields(name string) ([]Field, error) { return config.Styles.Fields(name) }
 func SetStyle(key, value string) error {
-	return set("styles", key, strings.Replace(value, ",", " ", -1))
+	return set("styles", key, strings.ReplaceAll(value, ",", " "))
 }
 
 func set(name, key, value string) error {