Skip to content

Commit 212d52e

Browse files
ejholmesclaude
andcommitted
Change annotation to mani-diffy.chime.com/skip: "true"
Updated the annotation to follow Kubernetes best practices: - Use forward domain format (mani-diffy.chime.com instead of com.chime.mani-diffy) - More intuitive naming: skip: "true" instead of render: "false" - Clearer intent and semantics Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 28ec01c commit 212d52e

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

main.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,20 @@ import (
2020

2121
const InfiniteDepth = -1
2222

23-
const renderAnnotation = "com.chime.mani-diffy/render"
23+
const skipAnnotation = "mani-diffy.chime.com/skip"
2424

2525
// shouldSkipRender checks if an Application should be skipped based on the
26-
// com.chime.mani-diffy/render annotation. Returns true if the annotation
27-
// is explicitly set to "false".
26+
// mani-diffy.chime.com/skip annotation. Returns true if the annotation
27+
// is explicitly set to "true".
2828
func shouldSkipRender(app *v1alpha1.Application) bool {
2929
if app.ObjectMeta.Annotations == nil {
3030
return false
3131
}
32-
value, ok := app.ObjectMeta.Annotations[renderAnnotation]
32+
value, ok := app.ObjectMeta.Annotations[skipAnnotation]
3333
if !ok {
3434
return false
3535
}
36-
return value == "false"
36+
return value == "true"
3737
}
3838

3939
// Renderer is a function that can render an Argo application.
@@ -134,9 +134,9 @@ func (w *Walker) walk(inputPath, outputPath string, depth, maxDepth int, visited
134134
continue
135135
}
136136

137-
// Skip Applications with the com.chime.mani-diffy/render annotation set to "false"
137+
// Skip Applications with the mani-diffy.chime.com/skip annotation set to "true"
138138
if shouldSkipRender(crd) {
139-
log.Printf("Skipping %s (com.chime.mani-diffy/render annotation is false)\n", crd.ObjectMeta.Name)
139+
log.Printf("Skipping %s (mani-diffy.chime.com/skip annotation is true)\n", crd.ObjectMeta.Name)
140140
continue
141141
}
142142

0 commit comments

Comments
 (0)