snapshot: Snapshot.Restore returns SnapshotConfig by value

Mirrors the DataDir flip: the snap-DB-side Restore was the only place
in the cmd/vm clone path that still forced \`*cfg\`/\`&cfg\` dancing.
Drop the pointer return on the interface, value-out from LocalFile, and
the cmd-side caller derefs once at the hypervisor boundary just like
DirectClone.

Author: CMGS

cmd/vm/run.go

@@ -128,14 +128,14 @@ func (h Handler) Clone(cmd *cobra.Command, args []string) error {
 	})
 	defer stop()
 
-	vmCfg, vmID, netProvider, networkConfigs, err := h.prepareClone(ctx, cmd, conf, *cfg)
+	vmCfg, vmID, netProvider, networkConfigs, err := h.prepareClone(ctx, cmd, conf, cfg)
 	if err != nil {
 		return err
 	}
 
 	logger.Infof(ctx, "cloning VM from snapshot %s ...", snapRef)
 
-	vm, cloneErr := hyper.Clone(ctx, vmID, vmCfg, networkConfigs, cfg, stream)
+	vm, cloneErr := hyper.Clone(ctx, vmID, vmCfg, networkConfigs, &cfg, stream)
 	if cloneErr != nil {
 		rollbackNetwork(ctx, netProvider, vmID)
 		return fmt.Errorf("clone VM: %w", cloneErr)

snapshot/localfile/localfile.go

@@ -183,13 +183,12 @@ func (lf *LocalFile) Delete(ctx context.Context, refs []string) ([]string, error
 	return deleted, nil
 }
 
-func (lf *LocalFile) Restore(ctx context.Context, ref string) (*types.SnapshotConfig, io.ReadCloser, error) {
+func (lf *LocalFile) Restore(ctx context.Context, ref string) (types.SnapshotConfig, io.ReadCloser, error) {
 	rec, err := lf.resolveRecord(ctx, ref)
 	if err != nil {
-		return nil, nil, err
+		return types.SnapshotConfig{}, nil, err
 	}
-	cfg := snapshotRecordToConfig(rec)
-	return &cfg, utils.TarDirStream(rec.DataDir, nil), nil
+	return snapshotRecordToConfig(rec), utils.TarDirStream(rec.DataDir, nil), nil
 }
 
 func (lf *LocalFile) RegisterGC(orch *gc.Orchestrator) {

snapshot/snapshot.go

@@ -40,7 +40,7 @@ type Snapshot interface {
 	// Delete removes snapshots by ID or name. Returns the list of actually deleted IDs.
 	Delete(ctx context.Context, refs []string) ([]string, error)
 	// Restore restores a snapshot by ID or name, returning the snapshot config and a data stream.
-	Restore(ctx context.Context, ref string) (*types.SnapshotConfig, io.ReadCloser, error)
+	Restore(ctx context.Context, ref string) (types.SnapshotConfig, io.ReadCloser, error)
 
 	// Export streams the snapshot as a raw tar archive.
 	// The archive includes a snapshot.json metadata entry followed by data files.