fix(keycloakx): also allow setting externalTrafficPolicy when service type is NodePort

Signed-off-by: Adrian Berger <adrian.berger@natron.io>

Author: adberger

charts/keycloakx/README.md

@@ -123,7 +123,7 @@ The following table lists the configurable parameters of the Keycloak-X chart an
 | `service.type`                                | The Service type                                                                                                                                                                                                                                                                  | `ClusterIP`                                                                                                                                                                             |
 | `service.loadBalancerIP`                      | Optional IP for the load balancer. Used for services of type LoadBalancer only                                                                                                                                                                                                    | `""`                                                                                                                                                                                    |
 | `loadBalancerSourceRanges`                    | Optional List of allowed source ranges (CIDRs). Used for service of type LoadBalancer only                                                                                                                                                                                        | `[]`                                                                                                                                                                                    |
-| `service.externalTrafficPolicy`               | Optional external traffic policy. Used for services of type LoadBalancer only                                                                                                                                                                                                     | `"Cluster"`                                                                                                                                                                             |
+| `service.externalTrafficPolicy`               | Optional external traffic policy. Used for services of type LoadBalancer & NodePort only                                                                                                                                                                                                     | `"Cluster"`                                                                                                                                                                             |
 | `service.httpPort`                            | The http Service port                                                                                                                                                                                                                                                             | `80`                                                                                                                                                                                    |
 | `service.httpNodePort`                        | The HTTP Service node port if type is NodePort                                                                                                                                                                                                                                    | `""`                                                                                                                                                                                    |
 | `service.httpsPort`                           | The HTTPS Service port                                                                                                                                                                                                                                                            | `8443`                                                                                                                                                                                  |

charts/keycloakx/templates/service-http.yaml

@@ -24,7 +24,7 @@ spec:
   loadBalancerSourceRanges:
     {{- toYaml .Values.service.loadBalancerSourceRanges | nindent 4 }}
   {{- end }}
-  {{- if eq "LoadBalancer" .Values.service.type }}
+  {{- if or (eq "LoadBalancer" .Values.service.type) (eq "NodePort" .Values.service.type) }}
   externalTrafficPolicy: {{ .Values.service.externalTrafficPolicy }}
   {{- end }}
   {{- if .Values.service.sessionAffinity }}

charts/keycloakx/values.yaml

@@ -267,7 +267,7 @@ service:
   # to connect to the LoadBalancer, e. g. will result in Security Groups
   # (or equivalent) with inbound source ranges allowed to connect
   loadBalancerSourceRanges: []
-  # When using Service type LoadBalancer, you can preserve the source IP seen in the container
+  # When using Service type LoadBalancer or NodePort, you can preserve the source IP seen in the container
   # by changing the default (Cluster) to be Local.
   # See https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer/#preserving-the-client-source-ip
   externalTrafficPolicy: "Cluster"