Bump maxTocSize to 150 MB

mtrmac · mtrmac · commit 2d3c4402fa7e · 2025-01-30T21:10:50.000+01:00
We have seen an image with:
- total size 1.43 GB
- uncompressed zstd:chunked manifest size of 91.7 MB
- uncompressed tar-split size (not constrained by maxTocSize) 310 MB

Without more infrastructure, we are just guessing about what
the system we are running on can support, so, for now, *shrug*, bump
the number.

Eventually we should stream the data from/to disk, making this
much less relevant; that makes building the infrastructure to
estimate available memory unattractive.

Signed-off-by: Miloslav Trmač &lt;mitr@redhat.com&gt;
diff --git a/pkg/chunked/compression_linux.go b/pkg/chunked/compression_linux.go
@@ -23,7 +23,7 @@ import (
 const (
 	// maxTocSize is the maximum size of a blob that we will attempt to process.
 	// It is used to prevent DoS attacks from layers that embed a very large TOC file.
-	maxTocSize = (1 << 20) * 50
+	maxTocSize = (1 << 20) * 150
 )
 
 var typesToTar = map[string]byte{

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ import (`
`23`	`23`	`const (`
`24`	`24`	`// maxTocSize is the maximum size of a blob that we will attempt to process.`
`25`	`25`	`// It is used to prevent DoS attacks from layers that embed a very large TOC file.`
`26`		`- maxTocSize = (1 << 20) * 50`
	`26`	`+ maxTocSize = (1 << 20) * 150`
`27`	`27`	`)`
`28`	`28`
`29`	`29`	`var typesToTar = map[string]byte{`