Docker apt source uses numeric version instead of codename on Debian 13 (Trixie), breaking apt-get update

[juliangall]

Description

On servers running Debian 13 (Trixie) — including Raspberry Pi OS based on Trixie — the Docker apt repository source file contains a numeric version (13) instead of the codename (trixie). This causes apt-get update to fail, which breaks both Docker installation (fallback path) and the server patch check feature.

Error Message

E: The repository 'https://download.docker.com/linux/debian 13 Release' does not have a Release file.

The correct URL should use trixie not 13:
https://download.docker.com/linux/debian/dists/trixie/stable

How It Manifests

1. Patch check notifications — CheckUpdates runs apt-get update -qq which fails because of the invalid Docker apt source, sending error emails: "Coolify: [ERROR] Failed to check patches"
2. Docker installation fallback — If get.docker.com fails and the manual fallback in InstallDocker runs, it writes a source file using ${VERSION_CODENAME} from /etc/os-release, which can be empty or missing on some Debian Trixie builds

Affected Files

• app/Actions/Server/CheckUpdates.php — runs apt-get update without checking/fixing the Docker apt source
• app/Actions/Server/InstallDocker.php — fallback Docker install uses ${VERSION_CODENAME} without a numeric-codename guard or UBUNTU_CODENAME fallback
• scripts/install.sh — same issue in install_docker_manually()
• other/nightly/install.sh — same issue

Suggested Fix

InstallDocker.php / install scripts: Use ${UBUNTU_CODENAME:-$VERSION_CODENAME} (handles Ubuntu derivatives like Pop!_OS), and add a fallback that maps numeric VERSION_ID values to codenames when VERSION_CODENAME is empty or numeric (13→trixie, 12→bookworm, 11→bullseye).

CheckUpdates.php: Before running apt-get update, detect and fix numeric versions in /etc/apt/sources.list.d/docker.list using the codename from /etc/os-release (which is already parsed earlier in the method).

Workaround

SSH into each affected server and run:

sudo sed -i 's|\(download.docker.com/linux/debian\) 13 |\1 trixie |g' /etc/apt/sources.list.d/docker.list

Version

v4.0.0-beta.470

[coderabbitai]

⚠️ Possible Duplicate Issue(s)

• [Bug]: Failed to configure server with Debian 13 #6729

🔗 Related PRs

#7012 - Add repository-based Docker installation fallbacks for Debian 13 and other major distros [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[themachinecorp]

/attempt #9455
/claim #9455

Implementation Plan

I've identified and fixed the root cause:

1. InstallDocker.php: Changed ${VERSION_CODENAME} to ${UBUNTU_CODENAME:-$VERSION_CODENAME} in the Docker apt sources.list entry. This matches the fix already present in install.sh.

2. CheckUpdates.php: Added a sed command to fix existing /etc/apt/sources.list.d/docker.list files that may contain 13 instead of trixie, applied before apt-get update.

PR submitted: #9469

Root cause: On Debian 13 (Trixie), $VERSION_CODENAME from /etc/os-release may be 13 (numeric) instead of trixie, causing invalid apt repository URLs.

[themachinecorp]

/bounty $100