Skip to content

Commit 646f865

Browse files
committed
fix(typing): satisfy stronger types at synchronizer and event-listener boundaries
1 parent 660e891 commit 646f865

4 files changed

Lines changed: 10 additions & 7 deletions

File tree

packages/core/src/RenderingEngine/BaseVolumeViewport.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ abstract class BaseVolumeViewport extends Viewport {
227227

228228
this.element.removeEventListener(
229229
Events.CAMERA_MODIFIED,
230-
volumeNewImageHandlerBound
230+
volumeNewImageHandlerBound as EventListener
231231
);
232232

233233
eventTarget.removeEventListener(
@@ -240,11 +240,11 @@ abstract class BaseVolumeViewport extends Viewport {
240240

241241
this.element.removeEventListener(
242242
Events.CAMERA_MODIFIED,
243-
volumeNewImageHandlerBound
243+
volumeNewImageHandlerBound as EventListener
244244
);
245245
this.element.addEventListener(
246246
Events.CAMERA_MODIFIED,
247-
volumeNewImageHandlerBound
247+
volumeNewImageHandlerBound as EventListener
248248
);
249249

250250
eventTarget.addEventListener(

packages/tools/src/synchronizers/synchronizers/createCameraPositionSynchronizer.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { createSynchronizer } from '../../store/SynchronizerManager';
22
import { Enums } from '@cornerstonejs/core';
33
import cameraSyncCallback from '../callbacks/cameraSyncCallback';
44
import type Synchronizer from '../../store/SynchronizerManager/Synchronizer';
5+
import type { ISynchronizerEventHandler } from '../../types';
56

67
const { CAMERA_MODIFIED } = Enums.Events;
78

@@ -18,7 +19,7 @@ export default function createCameraPositionSynchronizer(
1819
const cameraPositionSynchronizer = createSynchronizer(
1920
synchronizerName,
2021
CAMERA_MODIFIED,
21-
cameraSyncCallback
22+
cameraSyncCallback as ISynchronizerEventHandler
2223
);
2324

2425
return cameraPositionSynchronizer;

packages/tools/src/synchronizers/synchronizers/createPresentationViewSynchronizer.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { Enums, type Types } from '@cornerstonejs/core';
22
import { createSynchronizer } from '../../store/SynchronizerManager';
33
import presentationViewSyncCallback from '../callbacks/presentationViewSyncCallback';
44
import type Synchronizer from '../../store/SynchronizerManager/Synchronizer';
5+
import type { ISynchronizerEventHandler } from '../../types';
56

67
const { CAMERA_MODIFIED } = Enums.Events;
78

@@ -15,12 +16,12 @@ const { CAMERA_MODIFIED } = Enums.Events;
1516
*/
1617
export default function createPresentationViewSynchronizer(
1718
synchronizerName: string,
18-
options?: Types.ViewPresentation
19+
options?: Types.ViewPresentationSelector
1920
): Synchronizer {
2021
const presentationView = createSynchronizer(
2122
synchronizerName,
2223
CAMERA_MODIFIED,
23-
presentationViewSyncCallback,
24+
presentationViewSyncCallback as ISynchronizerEventHandler,
2425
{ viewPresentation: options }
2526
);
2627

packages/tools/src/synchronizers/synchronizers/createVOISynchronizer.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { createSynchronizer } from '../../store/SynchronizerManager';
22
import { Enums } from '@cornerstonejs/core';
33
import voiSyncCallback from '../callbacks/voiSyncCallback';
44
import type Synchronizer from '../../store/SynchronizerManager/Synchronizer';
5+
import type { ISynchronizerEventHandler } from '../../types';
56

67
type VOISynchronizerOptions = {
78
syncInvertState: boolean;
@@ -32,7 +33,7 @@ export default function createVOISynchronizer(
3233
const VOISynchronizer = createSynchronizer(
3334
synchronizerName,
3435
Enums.Events.VOI_MODIFIED,
35-
voiSyncCallback,
36+
voiSyncCallback as ISynchronizerEventHandler,
3637
{
3738
auxiliaryEvents: [
3839
{

0 commit comments

Comments
 (0)