Clicking on non selectable node doesn't unselect

[EliotRagueneau]

Environment info

• Cytoscape.js version : 3.31.0
• Browser/Node.js & version : Chromium Engine Version 140.0.7339.133

Current (buggy) behaviour
Clicking on a {selectable: false} node dose not behave as if the node doesn't exist

Desired behaviour

If the unselectable node is on the background, clicking on it should have the same behaviour as clicking on the background, aka unselect.
If there is another selectable node behind the unselectable, it should select the node behind.

That is even more true when the node is also not grabbable and pannable, as then it basically acts as a background element.
Minimum steps to reproduce

https://jsbin.com/kugetej/edit?js,output

Clicking on the red node should act as if you clicked on the element bellow, so for the first one it should select the white node, and on the second it should unselect since it is directly on background

For reviewers

Reviewers should ensure that the following tasks are carried out for incorporated issues:

• Ensure that the reporter has included a reproducible demo. They can easily fork this JSBin demo: http://jsbin.com/fiqugiq
• The issue has been associated with a corresponding milestone.
• The commits have been incorporated into the corresponding branches. Bug-fix patches go on
  • master and
  • unstable.
• The issue has been labelled as a bug, if necessary.

[simonfloris]

I've also noticed that hidden elements that have a styling that should remove them from interaction are interferring.

    style: {
        visibility: "hidden",
        display: "none",
        opacity: 0,
        events: "no" (or "yes"),
    },

This seems to have the same root cause as they are "non selectable" nodes, too.
A select event handler is called and teh target is referring to the correct selected node, the visible node that has been clicked.
But the visible node is not styled as selected and not getting selected. This should normally have happened before the select event handler fires.

[mikekucera]

@EliotRagueneau Thank you for the bug report. I'm not entirely sure the behaviour you describe is a bug. Just because a node isn't selectable doesn't mean it doesn't exist, especially if its clearly visible. I was able to get the JSBin to work the way I think you are asking for by adding 'events':'no' to the .unselectable case. Could you please verify that 'events':'no' works for you to give the desired behaviour?

@simonfloris I'm not entirely clear on what the bug is you are encountering. Could you please open a separate bug report and provide a JSBin and I'll take a look at it.