wip

Author: davidhemphill

src/Machinery.php

@@ -6,15 +6,16 @@ trait Machinery
 {
     public function transitionTo($machineKey, MachineryState $state, ?callable $sideEffect = null): MachineryState
     {
-        $sideEffect = $sideEffect ?? fn () => null;
+        if (!$this->canTransitionTo($machineKey, $state)) {
+            throw new InvalidStateTransition("Cannot transition from state [{$this->{$machineKey}->value}] to state [{$state->value}].");
+        }
 
-        $callable = function () use ($state, $machineKey, $sideEffect) {
-            $sideEffect($this);
-            $this->$machineKey = $state;
-            $this->save();
-        };
+        ($sideEffect ?? fn() => null)($this);
 
-        return $this->{$machineKey}->transitionTo($state, $callable);
+        $this->$machineKey = $state;
+        $this->save();
+
+        return $state;
     }
 
     public function canTransitionTo($machineKey, MachineryState $state): bool

src/MachineryEnumeration.php

@@ -12,7 +12,6 @@ trait MachineryEnumeration
      */
     public function transitionTo(MachineryState $state, ?callable $sideEffect = null): MachineryState
     {
-
         if (!$this->canTransitionTo($state)) {
             throw new InvalidStateTransition("Cannot transition from state [{$this->value}] to state [{$state->value}].");
         }