Update to v43 breaks webpack build

[klappradla]

Hi,

first off, thanks for the awesome work you're doing 🙏

I just updated to v43, but the change breaks the webpack build of my project with this error:

> webpack | ERROR in ./app/javascript/shared/utils/config.erb
> webpack | Module build failed (from ./node_modules/rails-erb-loader/index.js):
> webpack | Error: rails-erb-loader failed with code: 1
> webpack |     at ChildProcess.<anonymous> (/Users/max/code/bitcrowd/medgurus-learningplatform/node_modules/rails-erb-loader/index.js:129:16)
> webpack |     at ChildProcess.emit (node:events:514:28)
> webpack |     at maybeClose (node:internal/child_process:1091:16)
> webpack |     at Socket.<anonymous> (node:internal/child_process:449:11)
> webpack |     at Socket.emit (node:events:514:28)
> webpack |     at Pipe.<anonymous> (node:net:323:12)
> webpack |  @ ./app/javascript/shared/utils/bugsnag_client.js 2:0-34 4:13-33
> webpack |  @ ./app/javascript/bugsnag/index.js 1:0-40
> webpack |  @ ./app/javascript/packs/bugsnag.js 9:0-17

It seems like it's completely unrelated as I don't see anywhere that pagy is using the rails-erb-loader itself. So I was wondering: is there a way to opt out of any of the JavaScript parts of the gem?

[ddnexus]

Oh... maybe we missed to update the docs about the old webpack quirk?

See this and the other comments around this
#128 (comment)

Can you post the ./app/javascript/shared/utils/config.erb?

[klappradla]

Oh... maybe we missed to update the docs about the old webpack quirk?

See this and the other comments around this #128 (comment)

Can you post the ./app/javascript/shared/utils/config.erb?

This could have been it! I actually solved it completely different: I fully removed the gem and all traces of it in code and started completely from scratch. That worked and was all in all probably shorten then updating version per version (the app was very far behind).

But thanks a ton for your efforts 💜

[ddnexus]

Glad that you did it!

I will add more details about this matters.

This could have been it!

The current JavaScript section of the upgrade kind of implies it, but it should be explicit!

probably shorten then updating version per version (the app was very far behind)

It would probably be useful to mention that in the change log Breaking Changes section. It's actually a lot faster, especially if you don't have a lot of Pagy code, you will easily avoid a lot of reading.

Thank you!

[ddnexus]

is there a way to opt out of any of the JavaScript parts of the gem?

Not sure I get your question... if you mean using only the JavaScript that applies to your app... no. It's a single compact file that supports all the *_js helpers, and the compilation should take care of the unused code.

Obviously you don't need it unless you need the JavaScript support for using a *_js helper, but you already know that.