address review feedback

Author: derekparker

pkg/debugdetect/detect_darwin.go

@@ -18,7 +18,6 @@ const (
 )
 
 func detectDebuggerAttached() (bool, error) {
-	// Use sysctl to get process info and check P_TRACED flag
 	var info unix.KinfoProc
 
 	mib := [4]int32{unix.CTL_KERN, kernProc, kernProcPID, int32(os.Getpid())}
@@ -38,6 +37,5 @@ func detectDebuggerAttached() (bool, error) {
 		return false, fmt.Errorf("sysctl failed: %w", errno)
 	}
 
-	// Check if P_TRACED flag is set
 	return (info.Proc.P_flag & pTracedFlag) != 0, nil
 }

pkg/debugdetect/detect_freebsd.go

@@ -9,12 +9,10 @@ package debugdetect
 #cgo LDFLAGS: -lutil
 */
 import "C"
+
 import (
-	"bufio"
 	"fmt"
 	"os"
-	"strconv"
-	"strings"
 	"unsafe"
 )
 
@@ -24,62 +22,11 @@ const (
 )
 
 func detectDebuggerAttached() (bool, error) {
-	// Try sysctl first (more reliable)
-	attached, err := detectFreeBSDSysctl()
-	if err == nil {
-		return attached, nil
-	}
-
-	// Fall back to procfs if available
-	attachedProcfs, errProcfs := detectFreeBSDProcfs()
-	if errProcfs == nil {
-		return attachedProcfs, nil
-	}
-
-	// Both methods failed
-	return false, fmt.Errorf("sysctl failed: %v; procfs fallback failed: %v", err, errProcfs)
-}
-
-func detectFreeBSDSysctl() (bool, error) {
-	// Use kinfo_getproc to get process information
 	kp, err := C.kinfo_getproc(C.int(os.Getpid()))
 	if err != nil {
 		return false, fmt.Errorf("kinfo_getproc failed: %v", err)
 	}
 	defer C.free(unsafe.Pointer(kp))
 
-	// Check if P_TRACED flag is set in ki_flag
-	// ki_flag contains the process flags including P_TRACED
 	return (int(kp.ki_flag) & pTracedFlag) != 0, nil
 }
-
-func detectFreeBSDProcfs() (bool, error) {
-	// Try reading /proc/curproc/status (similar to Linux)
-	f, err := os.Open("/proc/curproc/status")
-	if err != nil {
-		return false, fmt.Errorf("failed to read /proc/curproc/status: %w", err)
-	}
-	defer f.Close()
-
-	scanner := bufio.NewScanner(f)
-	for scanner.Scan() {
-		line := scanner.Text()
-		if strings.HasPrefix(line, "TracerPid:") {
-			fields := strings.Fields(line)
-			if len(fields) < 2 {
-				return false, fmt.Errorf("malformed TracerPid line: %s", line)
-			}
-			pid, err := strconv.Atoi(fields[1])
-			if err != nil {
-				return false, fmt.Errorf("failed to parse TracerPid: %w", err)
-			}
-			return pid != 0, nil
-		}
-	}
-
-	if err := scanner.Err(); err != nil {
-		return false, fmt.Errorf("error reading /proc/curproc/status: %w", err)
-	}
-
-	return false, fmt.Errorf("TracerPid not found in /proc/curproc/status")
-}

pkg/debugdetect/detect_test.go

@@ -39,33 +39,6 @@ func TestIntegration_NotAttached(t *testing.T) {
 	}
 }
 
-func TestIsDebuggerAttached_NotAttached(t *testing.T) {
-	// This test should pass on all supported platforms when not debugging
-	attached, err := IsDebuggerAttached()
-
-	// On supported platforms, should not error
-	switch runtime.GOOS {
-	case "linux", "darwin", "windows", "freebsd":
-		if err != nil {
-			t.Fatalf("unexpected error on %s: %v", runtime.GOOS, err)
-		}
-		// We're running in normal test mode, should not be attached
-		// (unless someone is debugging the test itself, which is unlikely)
-		if attached {
-			t.Logf("WARNING: detected debugger attachment during test on %s", runtime.GOOS)
-			t.Logf("This is unusual but not necessarily wrong if you're debugging tests")
-		}
-	default:
-		// Unsupported platform - should return error
-		if err == nil {
-			t.Fatalf("expected error on unsupported platform %s", runtime.GOOS)
-		}
-		if attached {
-			t.Errorf("expected attached=false on unsupported platform, got true")
-		}
-	}
-}
-
 func TestIntegration_Attached(t *testing.T) {
 	// This test verifies that IsDebuggerAttached() returns true when
 	// the process is actually running under a debugger by using