canrunner: Set cyclic transmission on RunMessageTransmitter init

Check before starting the transmit loop if cyclic transmission has already been requested and enable it if so.

Author: Olle Sandberg

pkg/canrunner/run.go

@@ -152,6 +152,16 @@ func RunMessageTransmitter(
 		cyclicTransmissionTicker.Stop()
 		cyclicTransmissionTicker = nil
 	}
+	setCyclicTransmission := func() {
+		l.Lock()
+		isCyclicTransmissionEnabled := m.IsCyclicTransmissionEnabled()
+		l.Unlock()
+		if isCyclicTransmissionEnabled {
+			enableCyclicTransmission()
+		} else {
+			disableCyclicTransmission()
+		}
+	}
 	transmit := func() error {
 		l.Lock()
 		hook := m.BeforeTransmitHook()
@@ -173,20 +183,14 @@ func RunMessageTransmitter(
 	}
 	ctxDone := ctx.Done()
 	transmitEventChan := m.TransmitEventChan()
+	setCyclicTransmission()
 	wakeUpChan := m.WakeUpChan()
 	for {
 		select {
 		case <-ctxDone:
 			return nil
 		case <-wakeUpChan:
-			l.Lock()
-			isCyclicTransmissionEnabled := m.IsCyclicTransmissionEnabled()
-			l.Unlock()
-			if isCyclicTransmissionEnabled {
-				enableCyclicTransmission()
-			} else {
-				disableCyclicTransmission()
-			}
+			setCyclicTransmission()
 		case <-transmitEventChan:
 			if err := transmit(); err != nil {
 				return err

pkg/canrunner/run_test.go

@@ -91,6 +91,10 @@ func TestRunMessageTransmitter_TransmitEventMessage(t *testing.T) {
 	g.Go(func() error {
 		return canrunner.RunMessageTransmitter(ctx, tx, node, msg, clock)
 	})
+	// then message should be queried for if it has cyclic transmission enabled
+	node.EXPECT().Lock()
+	msg.EXPECT().IsCyclicTransmissionEnabled()
+	node.EXPECT().Unlock()
 	// then the node should be locked
 	node.EXPECT().Lock()
 	// and the time should be queried