fixed skipped pin group deletion in release build

julianspeith · julianspeith · commit 18a99ef567c5 · 2025-08-29T13:57:40.000+02:00
diff --git a/src/netlist/gate_library/gate_type.cpp b/src/netlist/gate_library/gate_type.cpp
@@ -402,7 +402,7 @@ namespace hal
             {
                 if (auto res = assign_pin_to_group(pin_group, *it, delete_empty_groups); res.is_error())
                 {
-                    assert(delete_pin_group(pin_group));
+                    delete_pin_group(pin_group);
                     return ERR(res.get_error());
                 }
             }
@@ -413,7 +413,7 @@ namespace hal
             {
                 if (auto res = assign_pin_to_group(pin_group, *it, delete_empty_groups); res.is_error())
                 {
-                    assert(delete_pin_group(pin_group));
+                    delete_pin_group(pin_group);
                     return ERR(res.get_error());
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,7 @@ namespace hal`
`402`	`402`	`{`
`403`	`403`	`if (auto res = assign_pin_to_group(pin_group, *it, delete_empty_groups); res.is_error())`
`404`	`404`	`{`
`405`		`- assert(delete_pin_group(pin_group));`
	`405`	`+ delete_pin_group(pin_group);`
`406`	`406`	`return ERR(res.get_error());`
`407`	`407`	`}`
`408`	`408`	`}`
`@@ -413,7 +413,7 @@ namespace hal`
`413`	`413`	`{`
`414`	`414`	`if (auto res = assign_pin_to_group(pin_group, *it, delete_empty_groups); res.is_error())`
`415`	`415`	`{`
`416`		`- assert(delete_pin_group(pin_group));`
	`416`	`+ delete_pin_group(pin_group);`
`417`	`417`	`return ERR(res.get_error());`
`418`	`418`	`}`
`419`	`419`	`}`