fixed missing enable pin and segfault it caused in GUI gatelib manager

julianspeith · julianspeith · commit 5941a995f4ac · 2026-04-20T17:44:18.000+02:00
diff --git a/plugins/gate_libraries/definitions/ice40ultra.hgl b/plugins/gate_libraries/definitions/ice40ultra.hgl
@@ -1391,6 +1391,21 @@
                         }
                     ]
                 },
+                {
+                    "name": "E",
+                    "direction": "input",
+                    "type": "enable",
+                    "ascending": false,
+                    "start_index": 0,
+                    "ordered": false,
+                    "pins": [
+                        {
+                            "name": "E",
+                            "direction": "input",
+                            "type": "enable"
+                        }
+                    ]
+                },
                 {
                     "name": "R",
                     "direction": "input",
diff --git a/plugins/gate_libraries/definitions/ice40ultra_hal.hgl b/plugins/gate_libraries/definitions/ice40ultra_hal.hgl
@@ -3686,6 +3686,21 @@
                         }
                     ]
                 },
+                {
+                    "name": "E",
+                    "direction": "input",
+                    "type": "enable",
+                    "ascending": false,
+                    "start_index": 0,
+                    "ordered": false,
+                    "pins": [
+                        {
+                            "name": "E",
+                            "direction": "input",
+                            "type": "enable"
+                        }
+                    ]
+                },
                 {
                     "name": "R",
                     "direction": "input",
diff --git a/plugins/gui/src/gatelibrary_management/gatelibrary_tab_widgets/gatelibrary_tab_truth_table.cpp b/plugins/gui/src/gatelibrary_management/gatelibrary_tab_widgets/gatelibrary_tab_truth_table.cpp
@@ -210,7 +210,7 @@ namespace hal
             for (int nsiCol = 0; nsiCol < nextStateInputs.size(); nsiCol++)
             {
                 int icol = inputColHash.value(nextStateInputs.at(nsiCol),-1);
-                Q_ASSERT(icol >= 0);
+                if (icol < 0) return false;
                 QString cellVal(irow & (1<<nsiCol) ? "H" : "L");
                 mTableWidget->setItem(irow, icol, new QTableWidgetItem(cellVal));
             }
@@ -231,7 +231,7 @@ namespace hal
             for (int nsiCol = 0; nsiCol < nextStateInputs.size(); nsiCol++)
             {
                 int icol = inputColHash.value(nextStateInputs.at(nsiCol),-1);
-                Q_ASSERT(icol >= 0);
+                if (icol < 0) return false;
                 mTableWidget->setItem(irow, icol, new QTableWidgetItem("X"));
             }
             if (icolClock >= 0)

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ namespace hal`
`210`	`210`	`for (int nsiCol = 0; nsiCol < nextStateInputs.size(); nsiCol++)`
`211`	`211`	`{`
`212`	`212`	`int icol = inputColHash.value(nextStateInputs.at(nsiCol),-1);`
`213`		`- Q_ASSERT(icol >= 0);`
	`213`	`+ if (icol < 0) return false;`
`214`	`214`	`QString cellVal(irow & (1<<nsiCol) ? "H" : "L");`
`215`	`215`	`mTableWidget->setItem(irow, icol, new QTableWidgetItem(cellVal));`
`216`	`216`	`}`
`@@ -231,7 +231,7 @@ namespace hal`
`231`	`231`	`for (int nsiCol = 0; nsiCol < nextStateInputs.size(); nsiCol++)`
`232`	`232`	`{`
`233`	`233`	`int icol = inputColHash.value(nextStateInputs.at(nsiCol),-1);`
`234`		`- Q_ASSERT(icol >= 0);`
	`234`	`+ if (icol < 0) return false;`
`235`	`235`	`mTableWidget->setItem(irow, icol, new QTableWidgetItem("X"));`
`236`	`236`	`}`
`237`	`237`	`if (icolClock >= 0)`