Skip to content

Bug: define_build_option function has logic error in native.alias #9676

@ELundby45

Description

@ELundby45

Summary

The define_build_option function in ynnpack/build_defs.bzl has a logic error in the native.alias definition (around line 33-41).

Issue

When the explicit_false condition is selected, the alias incorrectly points to ":" + explicit_true instead of ":" + explicit_false:

native.alias(
    name = name,
    actual = select({
        explicit_true: ":" + explicit_true,
        explicit_false: ":" + explicit_true,  # ← BUG: should be explicit_false
        "//conditions:default": ":" + default,
    }),
)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions