Strengthen/bug-fix compute_facet_owners#1291
Conversation
does not depend on how the cells shared by a facet are listed in the mesh data structure, but on the (local or global) cell identifiers of the cells sharing the facet. This guarantees a consistent owner, e.g., when the mesh is redistributed and information passed from the original mesh to the redistributed one
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1291 +/- ##
=======================================
Coverage 88.83% 88.83%
=======================================
Files 227 227
Lines 29769 29775 +6
=======================================
+ Hits 26445 26451 +6
Misses 3324 3324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates compute_facet_owners to support a user-provided local_to_global mapping and changes the facet owner selection rule to be based on global cell ordering (via that mapping), rather than relying on the topology’s adjacency ordering.
Changes:
- Extend
compute_facet_ownerswith an optionallocal_to_globalcallback (defaultidentity). - Change facet ownership selection from “first adjacent cell” to “adjacent cell with max global id”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
These will be sorted out soon in another branch.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
in compute_facet_owners
…p.jl into bug_fix_compute_facet_owners
underlying issue
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ap.jl into bug_fix_compute_facet_owners
No description provided.