v0.38 regression: gg continually re-tracks globally ignored .DS_Store files

[lgarron]

I was excited to update gg, but I'm now seeing an issue where it adds .DS_Store files any time I open a repo in it.

I ignore .DS_Store files globally because otherwise git and jj repos are a total pain on macOS: https://github.com/lgarron/dotfiles/blob/21db0b997d41625c62a3dc505baec6a2db4f9ca8/dotfiles/git/.config/git/ignore#L1

I'm certain gg is causing this because:

1. I can perform a whole bunch of operations in the jj commandline and VS Code without .DS_Store files being tracked,
2. .DS_Store files are immediately added when I open or focus gg, and
3. both of the above repeat for any given repo every time I abandon the commits with the .DS_Store files.

In fact, this reproduces even when I 1) abandon the commits inside gg, 2) switch from gg to any other unrelated app (say, Music.app), and 3) switch app focus directly back to gg.

This also happens in every single repo that I open.

Since this happens every single time I open gg, I'm going to downgrade gg for the time being. But I'm happy to try to get more repro details if it would help.

[gulbanana]

Sounds like a bug in global-gitignore handling. Where's your global ignore file, and what does it contain? Are you using any environment variables like XDG_CONFIG_HOME?

[gulbanana]

One more question: does jj st using jj-cli 0.38 also track those files? It could be a bug where gg has diverged too far from jj, or converged too close to it...

[lgarron]

Where's your global ignore file, and what does it contain?

https://github.com/lgarron/dotfiles/blob/21db0b997d41625c62a3dc505baec6a2db4f9ca8/dotfiles/git/.config/git/ignore#L1 (same link as above).

Are you using any environment variables like XDG_CONFIG_HOME?

Yes, although I set them to the defaults.

https://github.com/lgarron/dotfiles/blob/49f9a450332e240435b9e666743d65c56a1cfcc9/dotfiles/xdg-basedir-workarounds/.config/fish/xdg-basedir-workarounds.fish#L9-L12

One more question: does jj st using jj-cli 0.38 also track those files?

No, I'm on jj 0.38 and it ignores the files just as before (during jj status and all other operations I've used).

[gulbanana]

OK, I'm guessing you are on MacOS - the dirs crate deliberately does not use XDG_CONFIG_HOME on Macs. Git, on the other hand, only uses XDG_CONFIG_HOME. Since the point of this lookup is to find git's ignore file, I will stop using dirs.

[gulbanana]

Version 0.38.1 is out, which should fix this.

[lgarron]

I was able to upgrade to v038.2, and it seems the issue is gone. Thanks! 🤩