Go-VCR: Make domain name generation functions VCR-aware

[jar-b]

Description

The acctest.RandomDomainName and acctest.RandomSubdomain and acctest.RandomFQDomainName helper functions are currently underpinned by the Plugin SDK V2 based random string generation logic, which is not VCR-aware. These helper functions should be refactored to accept a *testing.T and call to the internal acctest.RandString generator to ensure deterministic domain names are generated upon test replay.

Important Facts and References

Relates #25602

Would you like to implement a relevant change?

No

[github-actions]

Community Guidelines

This comment is added to every new Issue to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Issue and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.