MAX Cube error setting Auto mode

[MassiPi]

The problem

Hello,
i have a ELV Max Cube integration, i can see info from wall and radiator thermostats, so it seems ok, but i can't set the mode of the heating to "auto".
I get a disconnection error and in logs i see this:

'MaxWallThermostat' object has no attribute 'get_programmed_temp_at'

with this traceback:
Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 205, in handle_call_service await hass.services.async_call( File "/usr/src/homeassistant/homeassistant/core.py", line 1965, in async_call response_data = await coro ^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/core.py", line 2005, in _execute_service return await cast( ^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 235, in handle_service return await service.entity_service_call( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 848, in entity_service_call response_data = task.result() # pop exception if have ^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1192, in async_request_call return await coro ^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 892, in _handle_entity_call result = await task ^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 497, in async_set_hvac_mode await self.hass.async_add_executor_job(self.set_hvac_mode, hvac_mode) File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run result = self.fn(*self.args, **self.kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/components/maxcube/climate.py", line 132, in set_hvac_mode self._set_target(MAX_DEVICE_MODE_AUTOMATIC, None) File "/usr/src/homeassistant/homeassistant/components/maxcube/climate.py", line 150, in _set_target self._cubehandle.cube.set_temperature_mode(self._device, temp, mode) File "/usr/local/lib/python3.11/site-packages/maxcube/cube.py", line 315, in set_temperature_mode thermostat.target_temperature = thermostat.get_programmed_temp_at( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'MaxWallThermostat' object has no attribute 'get_programmed_temp_at'

On the other side it seems i can set (for example) off or heat modes, but automatic is just crashing:

What version of Home Assistant Core has the issue?

core-2023.7.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

ELV Max!

Link to integration documentation on our website

https://www.home-assistant.io/integrations/maxcube/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 205, in handle_call_service
    await hass.services.async_call(
  File "/usr/src/homeassistant/homeassistant/core.py", line 1965, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2005, in _execute_service
    return await cast(
           ^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 235, in handle_service
    return await service.entity_service_call(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 848, in entity_service_call
    response_data = task.result()  # pop exception if have
                    ^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1192, in async_request_call
    return await coro
           ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 892, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 497, in async_set_hvac_mode
    await self.hass.async_add_executor_job(self.set_hvac_mode, hvac_mode)
  File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/maxcube/climate.py", line 132, in set_hvac_mode
    self._set_target(MAX_DEVICE_MODE_AUTOMATIC, None)
  File "/usr/src/homeassistant/homeassistant/components/maxcube/climate.py", line 150, in _set_target
    self._cubehandle.cube.set_temperature_mode(self._device, temp, mode)
  File "/usr/local/lib/python3.11/site-packages/maxcube/cube.py", line 315, in set_temperature_mode
    thermostat.target_temperature = thermostat.get_programmed_temp_at(
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'MaxWallThermostat' object has no attribute 'get_programmed_temp_at

Additional information

No response

[home-assistant]

maxcube documentation
maxcube source

[MassiPi]

it seems that in the maxcube api the "get_programmed_temp_at" is present only in the thermostat.py file ( https://github.com/uebelack/python-maxcube-api/blob/master/maxcube/thermostat.py )and not in the wallthermostat one ( https://github.com/uebelack/python-maxcube-api/blob/master/maxcube/wallthermostat.py ), it seems to me with no reason at all..
i don't think these python files are easily accessible for modification, am i wrong? i've never played with docker stuffs so i'm scared about breaking everything :)

[joostlek]

I don't know how good your programming knowledge is :)

I think the first thing that should be figured out is where it goes wrong. Apparently it expects another type of object. Where does it detect which type it should pick? Does your device have that support?

[MassiPi]

yes the code was developed getting the information about the weekly program from radiator thermostats and not from wall thermostats (opinable, at least)
So when you try to set automatic mode interacting with the wall thermostat (that is the only device returning also the room temperature) it simply breaks.
i'm trying to understand if getting the C command to be decoded also for wall thermostats is going to fix everything or not (it seems not, sadly).
Weekly program is obviously returned also for wall thermostats, but i think shifted

[MassiPi]

ok sorted this out, should i make a proposal for home assistant or for the source API ( https://github.com/uebelack/python-maxcube-api/tree/master ) that i fear is not even maintained anymore?

[joostlek]

Can you describe how you fixed it?

[MassiPi]

in the C command both the radiator thermostat and the wall thermostat reports the weekly program, that is used by the API to find the target temperature when changing mode.
In the original code, the program was took only from the radiator thermostat, so i added the same call also in wall thermostat. I only had to fix the way the program is calculated: in radiator thermostat it starts from byte 29 and ends with the payload, in wall thermostat it starts at byte 22, but is followed by 3 more bytes so i had to fix the length to 182.
It seems to work

[joostlek]

Right, the best way would be to create a pull request for that library. Apparently the maintainer was active yesterday so you have a chance to have it updated :)

[MassiPi]

otherwise it means i have to edit the code at every home assistant update? :)

[joostlek]

I think so, not 100% sure. Or you can make something with custom components, but first let's try it this way

[MassiPi]

ok so now i just need to understand how to do pull requests lol

[joostlek]

Create a fork of that repo, clone it, create a new branch, do your edit, commit, push. Then you can create a pull request from your fork to the original lib

[MassiPi]

thanks, i should have done.. let's see!
uebelack/python-maxcube-api#46

[issue-triage-workflows]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.