chores: better error management for evidences upload (#3576)

* chores: better error management for evidences upload

* fixup

* clean up on batch mode for tasks

Author: ab-smith

backend/core/validators.py

@@ -60,9 +60,18 @@ def validate_file_name(value):
         "xml",
         "msg",
         "eml",
+        "zip",
+        "7z",
+        "tar",
+        "gz",
+        "log",
+        "svg",
+        "mp4",
+        "mov",
+        "gif",
     ]
     parts = value.name.split(".")
-    extension = parts[-1]
+    extension = parts[-1].lower()
 
     if extension in allowed_extensions:
         if len(value.name) > 256:
@@ -74,4 +83,6 @@ def validate_file_name(value):
         )
         return value
     else:
-        raise ValidationError("An error occured with file extension")
+        raise ValidationError(
+            f"Unsupported file extension '.{extension}'. Allowed extensions: {', '.join(allowed_extensions)}"
+        )

backend/core/views.py

@@ -8223,10 +8223,18 @@ def post(self, request, *args, **kwargs):
                 revision.attachment = attachment
                 try:
                     revision.full_clean()
-                except ValidationError:
+                except ValidationError as e:
                     revision.attachment = old_attachment
+                    messages = []
+                    if hasattr(e, "message_dict"):
+                        for field_messages in e.message_dict.values():
+                            messages.extend(field_messages)
+                    elif hasattr(e, "messages"):
+                        messages = e.messages
+                    else:
+                        messages = [str(e.message)]
                     return Response(
-                        {"detail": "File too large or unsupported format."},
+                        {"detail": " ".join(messages)},
                         status=status.HTTP_400_BAD_REQUEST,
                     )
                 if old_attachment:

frontend/src/lib/components/Forms/ModelForm.svelte

@@ -228,7 +228,7 @@
 			if (form.message?.redirect) {
 				goto(getSecureRedirect(form.message.redirect));
 			}
-			if (form.valid) {
+			if (form.valid && !form.message?.error) {
 				if (parent && typeof parent.onConfirm === 'function') {
 					parent.onConfirm();
 				}

frontend/src/lib/utils/actions.ts

@@ -79,7 +79,10 @@ export async function handleErrorResponse({
 		return message(form, { warning: res.warning });
 	}
 	if (res.error || res.detail) {
-		setFlash({ type: 'error', message: safeTranslate(res.error || res.detail) }, event);
+		setFlash(
+			{ type: 'error', message: safeTranslate(res.error || res.detail), timeout: 10000 },
+			event
+		);
 		return message(form, { error: res.error || res.detail });
 	}
 	Object.entries(res).forEach(([key, value]) => {
@@ -149,8 +152,14 @@ export async function defaultWriteFormAction({
 				body: file
 			};
 			const fileUploadRes = await event.fetch(fileUploadEndpoint, fileUploadRequestInitOptions);
-			if (!fileUploadRes.ok)
+			if (!fileUploadRes.ok) {
+				// Clean up the created object if file upload fails during creation
+				if (action === 'create') {
+					const deleteEndpoint = `${BASE_API_URL}/${urlModel}/${writtenObject.id}/`;
+					await event.fetch(deleteEndpoint, { method: 'DELETE' });
+				}
 				return await handleErrorResponse({ event, response: fileUploadRes, form });
+			}
 		}
 	}
 

frontend/src/lib/utils/table.ts

@@ -2935,14 +2935,7 @@ export const batchActions: Partial<Record<urlModel, BatchActionConfig[]>> = {
 			icon: 'fa-solid fa-arrow-right-arrow-left',
 			field: 'status',
 			optionsEndpoint: 'task-nodes/status'
-		},
-		{
-			type: 'change_folder',
-			label: 'changeDomain',
-			icon: 'fa-solid fa-folder',
-			optionsEndpoint: 'folders?content_type=DO&content_type=GL'
-		},
-		{ type: 'delete', label: 'delete', icon: 'fa-solid fa-trash' }
+		}
 	],
 	'requirement-assessments': [
 		{

frontend/src/routes/+layout.svelte

@@ -112,7 +112,7 @@
 
 <svelte:head><link rel="icon" href="/favicon.ico" /></svelte:head>
 <Dialog components={modalRegistry} />
-<Toast />
+<Toast zIndex="z-[1000]" />
 {@render children?.()}
 
 {#if $flash}