Skip to content

Commit 6589e3b

Browse files
CopilotApollon77
andcommitted
Remove Node.js 18 support from adapter creator (#1154)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Apollon77 <11976694+Apollon77@users.noreply.github.com> Co-authored-by: Ingo Fischer <github@fischer-ka.de>
1 parent 6e195ba commit 6589e3b

4 files changed

Lines changed: 3 additions & 143 deletions

File tree

src/lib/core/questions.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -556,10 +556,10 @@ export const questionGroups: QuestionGroup[] = [
556556
message:
557557
"What's the minimum Node.js version you want to support?",
558558
initial: "20",
559-
choices: ["18", "20", "22"],
559+
choices: ["20", "22"],
560560
migrate: (ctx) => {
561561
if (ctx.hasDevDependency("@tsconfig/node18")) {
562-
return "18";
562+
return "20"; // For migrations upgrade to Node.js 20 as minimum
563563
} else if (ctx.hasDevDependency("@tsconfig/node20")) {
564564
return "20";
565565
} else if (ctx.hasDevDependency("@tsconfig/node22")) {
@@ -981,7 +981,7 @@ export interface Answers {
981981
| "code coverage"
982982
| "devcontainer"
983983
)[];
984-
nodeVersion?: "18" | "20" | "22";
984+
nodeVersion?: "20" | "22";
985985
title?: string;
986986
license?: string;
987987
// Not used on the CLI, but can be provided by the web UI for example

test/baselines/minNodeVersion_18/package.json

Lines changed: 0 additions & 80 deletions
This file was deleted.

test/baselines/minNodeVersion_18/tsconfig.json

Lines changed: 0 additions & 46 deletions
This file was deleted.

test/create-adapter.test.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -357,20 +357,6 @@ describe("adapter creation =>", () => {
357357
);
358358
});
359359

360-
it(`Node.js 18 as minimum`, async () => {
361-
const answers: Answers = {
362-
...baseAnswers,
363-
nodeVersion: "18",
364-
};
365-
await expectSuccess(
366-
"minNodeVersion_18",
367-
answers,
368-
(file) =>
369-
file.name === "package.json" ||
370-
file.name === "tsconfig.json",
371-
);
372-
});
373-
374360
it(`Node.js 20 as minimum`, async () => {
375361
const answers: Answers = {
376362
...baseAnswers,

0 commit comments

Comments
 (0)