test: some more teste

Author: kuisathaverat

pom.xml

@@ -219,20 +219,12 @@
       <plugin>
         <artifactId>maven-surefire-plugin</artifactId>
         <configuration>
-          <systemProperties>
-            <property>
-              <name>java.util.logging.config.file</name>
-              <value>src/test/resources/remoting_logger.properties</value>
-            </property>
-            <property>
-              <name>hudson.remoting.Launcher.pingIntervalSec</name>
-              <value>-1</value>
-            </property>
-            <property>
-              <name>hudson.slaves.ChannelPinger.pingIntervalSeconds</name>
-              <value>-1</value>
-            </property>
-          </systemProperties>
+          <systemPropertyVariables>
+            <java.util.logging.config.file>src/test/resources/remoting_logger.properties</java.util.logging.config.file>
+            <hudson.remoting.Launcher.pingIntervalSec>-1</hudson.remoting.Launcher.pingIntervalSec>
+            <hudson.slaves.ChannelPinger.pingIntervalSeconds>-1</hudson.slaves.ChannelPinger.pingIntervalSeconds>
+            <jenkins.test.timeout>-1</jenkins.test.timeout>
+          </systemPropertyVariables>
         </configuration>
       </plugin>
     </plugins>

src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ShellChannelImpl.java

@@ -23,25 +23,18 @@
  */
 package io.jenkins.plugins.sshbuildagents.ssh.mina;
 
-import java.io.BufferedInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
 import java.io.PipedInputStream;
 import java.io.PipedOutputStream;
-import java.time.Duration;
 import java.util.Collections;
 import java.util.concurrent.TimeUnit;
 import io.jenkins.plugins.sshbuildagents.ssh.ShellChannel;
 import org.apache.sshd.client.channel.ChannelSession;
 import org.apache.sshd.client.channel.ClientChannelEvent;
 import org.apache.sshd.client.session.ClientSession;
-import org.apache.sshd.common.channel.Channel;
-import org.apache.sshd.common.channel.ChannelListener;
-import org.apache.sshd.common.session.ReservedSessionMessagesHandler;
-import org.apache.sshd.common.session.Session;
-import org.apache.sshd.common.session.SessionHeartbeatController;
-import org.apache.sshd.common.util.buffer.Buffer;
+
 
 /**
  * Implements {@link ShellChannel} using the Apache Mina SSHD library https://github.com/apache/mina-sshd

src/test/java/io/jenkins/plugins/sshbuildagents/ssh/agents/AgentConnectionBase.java

@@ -52,7 +52,7 @@ public class AgentConnectionBase {
   public Retry retry = new Retry(3);
 
   @Rule
-  public Timeout globalTimeout= new Timeout(4, TimeUnit.MINUTES);
+  public Timeout globalTimeout= new Timeout(6, TimeUnit.MINUTES);
 
   protected boolean isSuccessfullyConnected(Node node) throws IOException, InterruptedException {
     boolean ret = false;

src/test/java/io/jenkins/plugins/sshbuildagents/ssh/agents/AgentRSA512ConnectionTest.java

@@ -1,10 +1,10 @@
 package io.jenkins.plugins.sshbuildagents.ssh.agents;
 
 import java.io.IOException;
-import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
+import org.jvnet.hudson.test.recipes.WithTimeout;
 import org.testcontainers.containers.GenericContainer;
 import org.testcontainers.images.builder.ImageFromDockerfile;
 import hudson.model.Descriptor;
@@ -45,15 +45,14 @@ public void connectionTests() throws IOException, InterruptedException, Descript
   }
 
   @Test
+  @WithTimeout(300)
   public void longConnectionTests() throws IOException, InterruptedException, Descriptor.FormException {
     Node node = createPermanentAgent(SSH_AGENT_NAME, agentContainer.getHost(), agentContainer.getMappedPort(SSH_PORT),
                                      SSH_AGENT_NAME + "/" + SSH_KEY_PATH, "");
     waitForAgentConnected(node);
     assertTrue(isSuccessfullyConnected(node));
-    for(int i=0;i<300;i++){
-      Thread.sleep(1000);
-      assertTrue(node.toComputer().isOnline());
-    }
+    Thread.sleep(60000);
+    assertTrue(node.toComputer().isOnline());
   }
 
 }

src/test/resources/remoting_logger.properties

@@ -5,7 +5,8 @@ java.util.logging.ConsoleHandler.formatter = java.util.logging.SimpleFormatter
 
 java.util.logging.FileHandler.append    = false
 java.util.logging.FileHandler.formatter = java.util.logging.SimpleFormatter
-java.util.logging.FileHandler.pattern   = log.%u.%g.log
+#the logs files are in the system temporal folder
+java.util.logging.FileHandler.pattern   = %t/ssh-build-agents-test-log.%u.%g.log
 
 hudson.remoting.level = FINE
 hudson.slaves.level = FINE