Fix/lint issues (#4)

* chore: remove unnecessary golangci.yml configuration file

Author: alenon

.github/release.yml

@@ -5,7 +5,9 @@ changelog:
   exclude:
     labels:
       - ignore for release
-      - skip-changelog
+      - wontfix
+      - question
+      - feature request
     authors:
       - dependabot
       - dependabot[bot]
@@ -15,7 +17,6 @@ changelog:
     - title: Breaking Changes 🚨
       labels:
         - breaking change
-        - breaking
     - title: Security Updates 🔒
       labels:
         - security
@@ -24,16 +25,13 @@ changelog:
       labels:
         - new feature
         - feature
-        - enhancement
-    - title: Improvements 🌱
+    - title: Improvements & Enhancements 🌱
       labels:
         - improvement
         - enhancement
     - title: Bug Fixes 🛠
       labels:
         - bug
-        - bugfix
-        - fix
     - title: Performance ⚡
       labels:
         - performance
@@ -50,10 +48,9 @@ changelog:
       labels:
         - test
         - testing
-    - title: Maintenance 🔧
+    - title: Maintenance & CI/CD 🔧
       labels:
         - maintenance
-        - internal
         - refactor
         - chore
         - ci

.github/workflows/pr-labels.yml

@@ -9,4 +9,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check if PR has allowed labels
-        uses: jfrog/.github/actions/pr-labels@main
+        uses: jfrog/.github/actions/pr-labels@main
+        with:
+          allowed-labels: 'bug,breaking change,new feature,feature,enhancement,improvement,security,vulnerability,performance,optimization,documentation,docs,test,testing,dependencies,deps,ci,build,maintenance,refactor,chore,style,question,wontfix,ignore for release,feature request'

.golangci.yml

@@ -26,7 +26,7 @@ BUILD_TIME?=$(shell date -u '+%Y-%m-%d_%H:%M:%S')
 LDFLAGS=-ldflags "-X main.Version=$(VERSION) -X main.Commit=$(COMMIT) -X main.BuildTime=$(BUILD_TIME)"
 
 # Test flags
-TEST_FLAGS=-v -race -coverprofile=$(COVERAGE_DIR)/coverage.out -covermode=atomic
+TEST_FLAGS= -race -coverprofile=$(COVERAGE_DIR)/coverage.out -covermode=atomic
 TEST_TIMEOUT=10m
 
 # Directories
@@ -89,11 +89,11 @@ test: ## Run all tests
 
 test-short: ## Run short tests
 	@echo "$(GREEN)Running short tests...$(NC)"
-	$(GOTEST) -short -v ./$(EVIDENCE_DIR)/...
+	$(GOTEST) -short ./$(EVIDENCE_DIR)/...
 
 test-integration: ## Run integration tests
 	@echo "$(GREEN)Running integration tests...$(NC)"
-	$(GOTEST) -v -tags=integration -timeout 30m ./$(EVIDENCE_DIR)/...
+	$(GOTEST) -tags=integration -timeout 30m ./$(EVIDENCE_DIR)/...
 
 test-unit: ## Run unit tests only
 	@echo "$(GREEN)Running unit tests...$(NC)"

Makefile

@@ -19,8 +19,12 @@ func TestCreateEvidence_Context(t *testing.T) {
 
 	assert.NoError(t, os.Setenv(coreUtils.SigningKey, "PGP"), "Failed to set env: "+coreUtils.SigningKey)
 	assert.NoError(t, os.Setenv(coreUtils.BuildName, buildName), "Failed to set env: JFROG_CLI_BUILD_NAME")
-	defer os.Unsetenv(coreUtils.SigningKey)
-	defer os.Unsetenv(coreUtils.BuildName)
+	defer func() {
+		assert.NoError(t, os.Unsetenv(coreUtils.SigningKey))
+	}()
+	defer func() {
+		assert.NoError(t, os.Unsetenv(coreUtils.BuildName))
+	}()
 
 	app := cli.NewApp()
 	app.Commands = []cli.Command{
@@ -216,8 +220,12 @@ func TestVerifyEvidence_Context(t *testing.T) {
 
 	assert.NoError(t, os.Setenv(coreUtils.SigningKey, "PGP"), "Failed to set env: "+coreUtils.SigningKey)
 	assert.NoError(t, os.Setenv(coreUtils.BuildName, buildName), "Failed to set env: JFROG_CLI_BUILD_NAME")
-	defer os.Unsetenv(coreUtils.SigningKey)
-	defer os.Unsetenv(coreUtils.BuildName)
+	defer func() {
+		assert.NoError(t, os.Unsetenv(coreUtils.SigningKey))
+	}()
+	defer func() {
+		assert.NoError(t, os.Unsetenv(coreUtils.BuildName))
+	}()
 
 	app := cli.NewApp()
 	app.Commands = []cli.Command{

evidence/cli/command_cli_test.go

@@ -188,7 +188,7 @@ func marshalEvidenceToGitLogEntryView(evidence []byte) (*model.GitLogEntryView,
 }
 
 func (c *createGitHubEvidence) committerReviewerEvidence() ([]byte, error) {
-	if c.createEvidenceBase.flagType != FlagTypeCommitterReviewer {
+	if c.flagType != FlagTypeCommitterReviewer {
 		return nil, errors.New("flag type must be gh-commiter")
 	}
 

evidence/create/create_github.go

@@ -98,7 +98,9 @@ func exportEvidenceToJsonFile(evidence []byte, outputFileName string) error {
 		return err
 	}
 
-	defer file.Close()
+	defer func() {
+		_ = file.Close()
+	}()
 
 	_, err = file.Write(evidence)
 	if err != nil {
@@ -118,7 +120,9 @@ func exportEvidenceToJsonlFile(data []byte, outputFileName string) error {
 	if err != nil {
 		return err
 	}
-	defer file.Close()
+	defer func() {
+		_ = file.Close()
+	}()
 
 	return writeEvidenceJsonl(data, file)
 }

evidence/get/get_base.go

@@ -44,7 +44,9 @@ func readTaskReport(path string) (map[string]string, error) {
 	if err != nil {
 		return nil, errorutils.CheckErrorf("failed to open report task file '%s': %v", path, err)
 	}
-	defer f.Close()
+	defer func() {
+		_ = f.Close()
+	}()
 
 	scanner := bufio.NewScanner(f)
 	for scanner.Scan() {

evidence/sonar/parser.go

@@ -9,7 +9,7 @@ func GetEnvVariable(envVarName string) (string, error) {
 	if key, exists := os.LookupEnv(envVarName); exists {
 		return key, nil
 	}
-	return "", fmt.Errorf("'%s'  field wasn't provided.", envVarName)
+	return "", fmt.Errorf("'%s' field wasn't provided", envVarName)
 }
 
 func IsRunningUnderGitHubAction() bool {

evidence/utils/environment.go

@@ -104,9 +104,6 @@ func TestSigstoreVerifier_VerifyTUFProviderError(t *testing.T) {
 func TestSigstoreVerifier_Creation(t *testing.T) {
 	verifier := newSigstoreVerifier()
 	assert.NotNil(t, verifier)
-
-	// Verify it implements the interface
-	var _ sigstoreVerifierInterface = verifier
 }
 
 func TestSigstoreVerifier_VerifyNilBundleAfterTUFSuccess(t *testing.T) {