Ensure correct and consistent use of millis64() (#170)

* Ensure correct and consistent use of millis64()

* Update Docs/ScheduleEvents.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply reviewer feedback: fix time source mixing, typos, doc comments, vcxproj filters, and strtoull

Agent-Logs-Url: https://github.com/SmartFuseBox/SmartFuseBox/sessions/9cc3b3e7-916a-4845-b9af-fabadb1c3d42

Co-authored-by: k3ldar <5587949+k3ldar@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: k3ldar <5587949+k3ldar@users.noreply.github.com>

Author: 3 people

Docs/BluetoothBle.md

@@ -85,7 +85,7 @@ Abstract base class. All services inherit from it and implement:
 | `begin()` | Create characteristics, initialise values, register with `BLE` |
 | `getServiceUUID()` | Return the service UUID string |
 | `getServiceName()` | Return a human-readable name for logging |
-| `loop(unsigned long)` | Periodic work — send notifications, update cached values |
+| `loop(uint64_t)` | Periodic work — send notifications, update cached values |
 | `getCharacteristicCount()` | Return number of characteristics (for diagnostics) |
 | `getBLEService()` | Return `void*` to the underlying `BLEService` (used by manager for advertising) |
 
@@ -258,7 +258,7 @@ public:
         return true;
     }
 
-    void loop(unsigned long currentMillis) override
+    void loop(uint64_t currentMillis) override
     {
         if (currentMillis - _lastUpdate >= 2000)
         {
@@ -275,7 +275,7 @@ public:
 private:
     BLEService* _service = nullptr;
     BLEIntCharacteristic* _charValue = nullptr;
-    unsigned long _lastUpdate = 0;
+    uint64_t _lastUpdate = 0;
 };
 ```
 

Docs/Local.md

@@ -117,7 +117,7 @@ On **Arduino Uno R4 WiFi**, the ANNA-B112 (BLE) and ESP32-S3 (WiFi) modules shar
 ## 4. Serial Initialisation Timeout
 
 ```cpp
-constexpr unsigned long serialInitTimeoutMs = 300;
+constexpr uint64_t serialInitTimeoutMs = 300;
 ```
 
 If `waitForConnection` is `true` when initialising serial, the firmware waits up to this many milliseconds for the USB serial connection before continuing with setup. Useful when debugging startup log messages that would otherwise be missed because the serial monitor opens after the board has already booted.

Docs/ScheduleEvents.md

@@ -24,7 +24,7 @@ Config (EEPROM)                  Persists ScheduledEvent array via ConfigManager
      │  read by
      ▼
 ScheduleController               Runtime engine — called every loop()
-  ├── isTriggerDue()             Evaluates trigger against current time / millis()
+  ├── isTriggerDue()             Evaluates trigger against current time / millis64()
   ├── isConditionMet()           Evaluates guard condition
   ├── executeAction()            Drives RelayController
   └── updatePulses()             Turns off relays when pulse duration expires
@@ -215,7 +215,7 @@ The scheduler overview is also included in the main status response at `GET /`.
 _scheduleController.begin();   // subscribes to MessageBus events
 
 // loop()
-_scheduleController.update(millis());
+_scheduleController.update(SystemFunctions::millis64());
 ```
 
 ### Evaluation Cycle
@@ -259,9 +259,9 @@ State is held in stack-allocated arrays indexed by event slot. It is **not persi
 |---|---|---|
 | `_lastFiredDay` | `uint32_t[20]` | Packed YYYYMMDD of last trigger evaluation |
 | `_lastFiredMinute` | `uint16_t[20]` | Minute-of-day (0–1439) of last trigger evaluation |
-| `_lastIntervalFireMs` | `unsigned long[20]` | `millis()` timestamp of last interval fire |
-| `_pulseStartMs` | `unsigned long[20]` | `millis()` when `RelayPulse` began |
-| `_pulseDurMs` | `unsigned long[20]` | `RelayPulse` duration in milliseconds |
+| `_lastIntervalFireMs` | `uint64_t[20]` | `SystemFunctions::millis64()` timestamp of last interval fire |
+| `_pulseStartMs` | `uint64_t[20]` | `SystemFunctions::millis64()` when `RelayPulse` began |
+| `_pulseDurMs` | `uint64_t[20]` | `RelayPulse` duration in milliseconds |
 | `_pulseRelayIdx` | `uint8_t[20]` | Relay to turn off when pulse expires |
 | `_pulseActive` | `bool[20]` | Whether a pulse is currently running for the slot |
 

Docs/Sensors.md

@@ -345,7 +345,7 @@ protected:
         pinMode(_sensorPin, INPUT);
     }
 
-    unsigned long update() override
+    uint64_t update() override
     {
         _lastValue = analogRead(_sensorPin);
 

Docs/Warnings.md

@@ -94,7 +94,7 @@ uint32_t local  = warningManager.getLocalWarningsMask();
 uint32_t remote = warningManager.getRemoteWarningsMask();
 
 // Called from the main loop — drives heartbeat and connection state
-warningManager.update(millis());
+warningManager.update(SystemFunctions::millis64());
 
 // Called from AckCommandHandler when ACK:F0=ok arrives
 warningManager.notifyHeartbeatAck();

SmartFuseBox/BaseSensor.h

@@ -114,7 +114,7 @@ class BaseSensor : public BaseSensorHandler, public JsonVisitor
 
 	virtual void getMqttValue(uint8_t channelIndex, char* buffer, size_t size) const = 0;
 
-	virtual unsigned long getMqttPublishIntervalMs(uint8_t channelIndex) const
+	virtual uint64_t getMqttPublishIntervalMs(uint8_t channelIndex) const
 	{
 		(void)channelIndex;
 		return 1000; // Default: publish every 1 second

SmartFuseBox/BinaryPresenceSensor.cpp

@@ -108,11 +108,11 @@ void BinaryPresenceSensor::initialize()
 	_lastState = digitalRead(_sensorPin);
 }
 
-unsigned long BinaryPresenceSensor::update()
+uint64_t BinaryPresenceSensor::update()
 {
     if (_directPulseActive && _relayController)
     {
-        if (SystemFunctions::hasElapsed(millis(), _directPulseStartMs, _directPulseDurMs))
+        if (SystemFunctions::hasElapsed(_directPulseStartMs, _directPulseDurMs))
         {
             _relayController->setRelayState(_directPulseRelayIdx, false);
             _directPulseActive = false;
@@ -176,8 +176,8 @@ void BinaryPresenceSensor::executeAction(ExecutionActionType actionType, const u
 
         uint8_t relayIdx = payload[0];
         _relayController->setRelayState(relayIdx, true);
-        _directPulseStartMs = millis();
-        _directPulseDurMs = static_cast<unsigned long>(durationSec) * MillisecondsPerSecond;
+        _directPulseStartMs = SystemFunctions::millis64();
+        _directPulseDurMs = static_cast<uint64_t>(durationSec) * MillisecondsPerSecond;
         _directPulseRelayIdx = relayIdx;
         _directPulseActive = true;
         break;

SmartFuseBox/BinaryPresenceSensor.h

@@ -26,7 +26,7 @@
 #include "RelayController.h"
 #include "SensorCommandHandler.h"
 
-constexpr unsigned long BinaryPresenceCheckMs = 300;
+constexpr uint64_t BinaryPresenceCheckMs = 300;
 
 /**
  * @brief Sensor handler for binary presence monitoring.
@@ -44,18 +44,18 @@ class BinaryPresenceSensor : public BaseSensor, public BroadcastLoggerSupport
 	const uint8_t _sensorPin;
 	int _activeState; // HIGH or LOW depending on sensor type
 	int _lastState;
-	unsigned long _lastChangeMs;
+	uint64_t _lastChangeMs;
 
 	ExecutionActionType _onDetectedAction;
 	uint8_t _onDetectedPayload[ConfigSchedulerPayloadSize];
 	ExecutionActionType _onClearAction;
 	uint8_t _onClearPayload[ConfigSchedulerPayloadSize];
 
 	// Pulse state for sensor-triggered direct actions (single dedicated slot)
-	bool          _directPulseActive;
-	unsigned long _directPulseStartMs;
-	unsigned long _directPulseDurMs;
-	uint8_t       _directPulseRelayIdx;
+	bool _directPulseActive;
+	uint64_t _directPulseStartMs;
+	uint64_t _directPulseDurMs;
+	uint8_t _directPulseRelayIdx;
 
 
 #if defined(MQTT_SUPPORT)
@@ -67,7 +67,7 @@ class BinaryPresenceSensor : public BaseSensor, public BroadcastLoggerSupport
 
 protected:
 	void initialize() override;
-	unsigned long update() override;
+	uint64_t update() override;
 
 public:
 	BinaryPresenceSensor(MessageBus* messageBus, BroadcastManager* broadcastManager, SensorCommandHandler* sensorCommandHandler,

SmartFuseBox/BluetoothManager.cpp

@@ -130,7 +130,7 @@ bool BluetoothManager::initializeServices()
 
 void BluetoothManager::loop()
 {
-    unsigned long currentMillis = millis();
+    uint64_t currentMillis = SystemFunctions::millis64();
 
     // Poll for BLE events
     BLE.poll();

SmartFuseBox/BluetoothManager.h

@@ -26,6 +26,7 @@
 #include "BluetoothServiceBase.h"
 #include "WarningManager.h"
 #include "LoggingSupport.h"
+#include "SystemFunctions.h"
 
 /**
  * @brief Central coordinator for Bluetooth BLE communication.
@@ -146,7 +147,7 @@ class BluetoothManager : public SingleLoggerSupport
     void* _server;  // BLEServer* (void* to avoid exposing BLE library headers)
     bool _isAdvertising;
     bool _deviceConnected;
-    unsigned long _lastLoopTime;
+    uint64_t _lastLoopTime;
     const char* _deviceName;
 
     /**