Refactor pubspek boolean logic and update web assets instructions (#126)

- Add GEMINI.md to document the correct workflow for modifying and recompiling web assets within pubviz.
- Simplify boolean logic for hasFlutterPluginKey in pubspek.dart using Dart 3 record pattern matching.
- Replace .forEach with for-in loops in pubspek.dart and remove associated lint ignores.
- Update UI implementations in _example_src and regenerate corresponding web assets.

Author: kevmoo

GEMINI.md

@@ -0,0 +1,47 @@
+# Pubviz AI Agent Instructions
+
+These instructions help guide AI agents when making changes to this repository.
+
+## Web Assets Workflow (`_example_src` vs `lib/assets`)
+
+The `pubviz` application includes a compiled web frontend that is bundled
+directly into the Dart package. It is critical to understand the distinction
+between the source files and the compiled outputs:
+
+1. **Source of Truth (`_example_src/`)**:
+   - All web application source code (HTML, CSS, Dart) lives in the
+     `_example_src` directory.
+   - **Make all web-related UI or logic edits here.** Do NOT manually edit
+     files in `lib/assets/`.
+
+2. **Compiled Output (`lib/assets/`)**:
+   - This directory contains the final generated web artifacts (Compiled JS,
+     WASM, CSS, copied HTML, etc.) ensuring offline functionality.
+   - It also contains `build_inputs.json`, which tracks the `SHA-256` hashes
+     of the input files (`_example_src`, `lib`, `build.yaml`, `pubspec.yaml`)
+     to ensure the cache isn't stale.
+
+3. **Rebuilding Assets**:
+   - Whenever you modify *anything* in `_example_src/`, `lib/`, `build.yaml`, 
+     or `pubspec.yaml`, you **MUST** run the following command to recompile
+     the assets and sync them to `lib/assets/`:
+     ```bash
+     dart tool/update_assets.dart
+     ```
+   - If you fail to run this step, the CI test
+     `ensure_web_assets_built_test.dart` will fail because the
+     `build_inputs.json` hash will no longer match the source files on disk,
+     or the manual static byte checks will fail.
+
+## Code Generation (`build_runner`)
+- `pubviz` uses `build_cli` (for `lib/src/options.dart`) and `build_version`
+  (for `lib/src/version.dart`).
+- The `dart tool/update_assets.dart` script invokes `build_runner build` under
+  the hood, so running it will also safely update `options.g.dart` and
+  `version.dart` if their inputs changed.
+
+## Code Hygiene
+- Use `dart format .` after making Dart file changes to maintain spacing/styling
+  rules.
+- Validate your work with `dart test` (or `dart test -P presubmit`) to ensure
+  your modifications didn't break functionality.

_example_src/index.html

@@ -19,6 +19,7 @@
         </div>
         <div id="controls-footer">
           <a href="https://pub.dev/packages/pubviz" target="_blank" rel="noopener noreferrer">package:pubviz</a>
+          <span id="version">vXYZ</span>
         </div>
       </div>
       <div id="graph-wrapper">

_example_src/web_app.dart

@@ -7,6 +7,7 @@ import 'dart:convert' show LineSplitter, htmlEscape;
 import 'dart:js_interop';
 
 import 'package:pubviz/src/colors.dart';
+import 'package:pubviz/src/version.dart';
 import 'package:web/web.dart';
 
 typedef DepInfo = ({
@@ -74,6 +75,9 @@ void main() {
         toggleZoom();
     }
   });
+
+  (document.querySelector('#version') as HTMLSpanElement).textContent =
+      'v$packageVersion';
 }
 
 Future<void> _process() async {

analysis_options.yaml

@@ -27,6 +27,7 @@ linter:
     - prefer_final_locals
     - require_trailing_commas
     - unnecessary_await_in_return
+    - unnecessary_ignore
     - use_if_null_to_convert_nulls_to_bools
     - use_raw_strings
     - use_string_buffers

lib/assets/build_inputs.json

@@ -1,8 +1,8 @@
 {
   "_example_src/favicon.ico": "39ab6b867a1c4c75019506267b3b4ce7cc60fb2ba66870e6485b4e31f6265a7c",
-  "_example_src/index.html": "dff96f3cde0deeee4ffbe702244f8eb043d817cc01c273226241fbb023e8b9ab",
+  "_example_src/index.html": "f2be81879aff39d920483cab30d6b3fa56bd4a528c4a853904b77644b67f6634",
   "_example_src/style.css": "9123572a80468f0788d1b9a47a5f9c7d0ea2228646101f48da35eb9392788dfb",
-  "_example_src/web_app.dart": "6ddf7cafbd002069d8b6da0e125f2d0543ed6f52f1f764a791d3b3023771a92d",
+  "_example_src/web_app.dart": "aa883182a767490e2d38617b3d8f383cc8ada028356d6e0f7b8cd260d856592b",
   "build.yaml": "4afbf68cad8a8c6117d931c66905e172804d9541b3fd336016b6ff4549c2acdf",
   "lib/pubviz.dart": "660265e3bfb4da0739beb5271d3f04fc01ef32e0a58972b023bd84166a78d61e",
   "lib/src/colors.dart": "802bcd9a31b062865654c1a5300292164ff8f7f003caf2c8277225177ce74e56",
@@ -13,7 +13,7 @@
   "lib/src/options.g.dart": "f0d5e6701e92162b8470b9b35f0ca48bf8e4ad60fb2e82e0faaa858d3f72173a",
   "lib/src/outdated_info.dart": "23a6b6703d4a67933c747afda2bd5fee7fded43448239dd84243512b58f16c8a",
   "lib/src/pub_data_service.dart": "a288875418a1c50163465ba6bba0df32ea94d8de02e1d389f1aecf80829c4db0",
-  "lib/src/pubspek.dart": "67ae4b64b2a5b62b033f16f94065013084fad1df3e4d222b973cd1827c8e3258",
+  "lib/src/pubspek.dart": "085f028d02097617cb50bd1e22dd5f799a18e52f3eddf5ec30674269a3ae1a52",
   "lib/src/service.dart": "602e1ed24835efb2a1a15706d487f5d024641c7bd83fc6ca8ddef9287acebf6b",
   "lib/src/terminate.dart": "43459f9bf9b821d342f32b9ad1ce4fed9b51fe1cb96d7efd9858045293afce50",
   "lib/src/update_order.dart": "c47cabe4d41f7113f81fd769bfe0d9a20f2f27fb305f660772c6db1b2d28d120",

lib/assets/index.html

@@ -19,6 +19,7 @@
         </div>
         <div id="controls-footer">
           <a href="https://pub.dev/packages/pubviz" target="_blank" rel="noopener noreferrer">package:pubviz</a>
+          <span id="version">vXYZ</span>
         </div>
       </div>
       <div id="graph-wrapper">

lib/assets/web_app.dart2js.js

@@ -249,11 +249,11 @@ Og(a){return A.rL(a,new Error())},
 rL(a,b){var s
 if(a==null)a=new A.Ez()
 b.dartException=a
-s=A.D
+s=A.Ju
 if("defineProperty" in Object){Object.defineProperty(b,"message",{get:s})
 b.name=""}else b.toString=s
 return b},
-D(){return J.Rh(this.dartException)},
+Ju(){return J.Rh(this.dartException)},
 vh(a,b){throw A.rL(a,b==null?new Error():b)},
 cW(a,b,c){var s
 if(b==null)b=0
@@ -578,7 +578,7 @@ switch(a0){case 5:case 1:case 2:case 3:case 4:return a2
 case 6:s=a2.x
 r=A.PL(a1,s,a3,a4)
 if(r===s)return a2
-return A.B(a1,r,!0)
+return A.D(a1,r,!0)
 case 7:s=a2.x
 r=A.PL(a1,s,a3,a4)
 if(r===s)return a2
@@ -715,7 +715,7 @@ else if(s===t.N)r=A.Bt
 else if(s===t.y)r=A.p8
 else if(s===t.H)r=A.z5
 else if(s===t.i)r=A.rV
-else if(s===t.m)r=A.AN
+else if(s===t.m)r=A.A
 s.a=r
 return s.a(a)},
 YO(a){var s=this
@@ -791,7 +791,7 @@ throw A.rL(A.Lz(a,"String"),new Error())},
 ra(a){if(typeof a=="string")return a
 if(a==null)return a
 throw A.rL(A.Lz(a,"String?"),new Error())},
-AN(a){if(A.Vl(a))return a
+A(a){if(A.Vl(a))return a
 throw A.rL(A.Lz(a,"JSObject"),new Error())},
 wI(a){if(a==null)return a
 if(A.Vl(a))return a
@@ -900,7 +900,7 @@ s.as=c
 r=A.BD(a,s)
 a.eC.set(c,r)
 return r},
-B(a,b,c){var s,r=b.as+"?",q=a.eC.get(r)
+D(a,b,c){var s,r=b.as+"?",q=a.eC.get(r)
 if(q!=null)return q
 s=A.ll(a,b,r,c)
 a.eC.set(r,s)
@@ -929,7 +929,7 @@ r.w=7
 r.x=b
 r.as=c
 return A.BD(a,r)},
-H(a,b){var s,r,q=""+b+"^",p=a.eC.get(q)
+B(a,b){var s,r,q=""+b+"^",p=a.eC.get(q)
 if(p!=null)return p
 s=new A.Jc(null,null)
 s.w=13
@@ -1016,7 +1016,7 @@ return A.BD(a,l)},
 u(a,b,c,d){return{u:a,e:b,r:c,s:[],p:0,n:d}},
 x(a){var s,r,q,p,o,n,m,l=a.r,k=a.s
 for(s=l.length,r=0;r<s;){q=l.charCodeAt(r)
-if(q>=48&&q<=57)r=A.A(r+1,q,l,k)
+if(q>=48&&q<=57)r=A.H(r+1,q,l,k)
 else if((((q|32)>>>0)-97&65535)<26||q===95||q===36||q===124)r=A.t(a,r,l,k,!1)
 else if(q===46)r=A.t(a,r,l,k,!0)
 else{++r
@@ -1027,7 +1027,7 @@ case 33:k.push(!0)
 break
 case 59:k.push(A.K(a.u,a.e,k.pop()))
 break
-case 94:k.push(A.H(a.u,k.pop()))
+case 94:k.push(A.B(a.u,k.pop()))
 break
 case 35:k.push(A.m(a.u,5,"#"))
 break
@@ -1043,7 +1043,7 @@ break
 case 38:A.I(a,k)
 break
 case 63:p=a.u
-k.push(A.B(p,A.K(p,a.e,k.pop()),a.n))
+k.push(A.D(p,A.K(p,a.e,k.pop()),a.n))
 break
 case 47:p=a.u
 k.push(A.f(p,A.K(p,a.e,k.pop()),a.n))
@@ -1081,7 +1081,7 @@ r=n+1
 break
 default:throw"Bad character "+q}}}m=k.pop()
 return A.K(a.u,a.e,m)},
-A(a,b,c,d){var s,r,q=b-48
+H(a,b,c,d){var s,r,q=b-48
 for(s=c.length;a<s;++a){r=c.charCodeAt(a)
 if(!(r>=48&&r<=57))break
 q=q*10+(r-48)}d.push(q)
@@ -1679,13 +1679,18 @@ _.c=b
 _.d=c
 _.e=d},
 vN:function vN(a){this.a=a},
-E2(){A.i()
+E2(){var s,r
+A.i()
 A.J($.v(),"wheel",new A.e(),!1)
 A.J($.l(),"wheel",new A.L(),!1)
-var s=new A.b()
+s=new A.b()
 A.J($.o(),"click",new A.C(s),!1)
 A.J($.n(),"change",new A.w(),!1)
-A.J(v.G.window,"keydown",new A.em(s,new A.h()),!1)},
+r=v.G
+A.J(r.window,"keydown",new A.em(s,new A.h()),!1)
+r=r.document.querySelector("#version")
+s=r==null?A.A(r):r
+s.textContent="v5.0.0"},
 i(){var s=0,r=A.FX(t.n),q=1,p=[],o=[],n,m,l,k,j,i,h,g,f
 var $async$i=A.lz(function(a,b){if(a===1){p.push(b)
 s=q}for(;;)switch(s){case 0:h=$.oa
@@ -1732,7 +1737,7 @@ a=new A.oi(i,new A.AR(),A.Lh(i).C("oi<cX.E>")).h(0,"\n")
 i=v.G
 i.document.querySelector("#graph-container").insertAdjacentHTML("beforeend",a)
 i=i.document.querySelector("svg")
-if(i==null)i=A.AN(i)
+if(i==null)i=A.A(i)
 $.oa=i
 i=A.it(i.querySelectorAll("g.node"))
 i=A.K1(i,new A.lg(),i.$ti.C("cX.E"),t.a)
@@ -2766,7 +2771,7 @@ $S:18}
 A.w0.prototype={
 $1(a){var s
 if($.fq==null){s=a.currentTarget
-if(s==null)s=A.AN(s)
+if(s==null)s=A.A(s)
 A.ws(s,this.a,this.b)}},
 $S:1}
 A.FL.prototype={
@@ -2776,7 +2781,7 @@ A.yx.prototype={
 $1(a){var s,r
 a.stopPropagation()
 s=a.currentTarget
-if(s==null)s=A.AN(s)
+if(s==null)s=A.A(s)
 if($.fq===s){$.fq=null
 r=null}else{$.fq=s
 r=s}if(r==null)r=s
@@ -3051,17 +3056,17 @@ s($,"X0","t8",()=>A.CU(B.h0))
 s($,"N8","jv",()=>{A.w4()
 return $.zI})
 s($,"UO","o",()=>{var r=A.aJ(A.Qh(A.pk(),"document"),"querySelector","#hamburgerBtn")
-return r==null?A.AN(r):r})
+return r==null?A.A(r):r})
 s($,"bV","E1",()=>{var r=A.aJ(A.Qh(A.pk(),"document"),"querySelector","#controls-panel")
-return r==null?A.AN(r):r})
+return r==null?A.A(r):r})
 s($,"xh","n",()=>{var r=A.aJ(A.Qh(A.pk(),"document"),"querySelector","#zoomCheckbox")
-return r==null?A.AN(r):r})
+return r==null?A.A(r):r})
 s($,"y8","v",()=>{var r=A.aJ(A.Qh(A.pk(),"document"),"querySelector","#deps-in-box")
-return r==null?A.AN(r):r})
+return r==null?A.A(r):r})
 s($,"JX","l",()=>{var r=A.aJ(A.Qh(A.pk(),"document"),"querySelector","#deps-out-box")
-return r==null?A.AN(r):r})
+return r==null?A.A(r):r})
 s($,"pt","Mc",()=>{var r=A.aJ(A.Qh(A.pk(),"document"),"querySelector","#dot")
-return A.AF(A.DF(B.xB.bS(A.Bt(A.Qh(r==null?A.AN(r):r,"innerHTML")))),t.N)})})();(function nativeSupport(){!function(){var s=function(a){var m={}
+return A.AF(A.DF(B.xB.bS(A.Bt(A.Qh(r==null?A.A(r):r,"innerHTML")))),t.N)})})();(function nativeSupport(){!function(){var s=function(a){var m={}
 m[a]=1
 return Object.keys(hunkHelpers.convertToFastObject(m))[0]}
 v.getIsolateTag=function(a){return s("___dart_"+a+v.isolateTag)}

lib/assets/web_app.mjs

@@ -235,6 +235,7 @@ class CompiledApp {
       _4750: x0 => x0.currentTarget,
       _4798: x0 => x0.length,
       _4857: x0 => x0.textContent,
+      _4858: (x0,x1) => { x0.textContent = x1 },
       _4862: () => globalThis.document,
       _5273: x0 => x0.id,
       _5274: (x0,x1) => { x0.id = x1 },