Skip to content

Commit 5e8c6d6

Browse files
committed
frontend: Deployment: Show min ready, progress deadline, history limit
Surface spec.minReadySeconds, spec.progressDeadlineSeconds and spec.revisionHistoryLimit when rendering a Deployment through the shared workload Details, so users can review rollout-tuning knobs that were previously only visible in the YAML. The rows are added through the kind-keyed extra-info registry in workload/extraInfo.tsx and each hides itself when the underlying field is unset.
1 parent b62c07f commit 5e8c6d6

3 files changed

Lines changed: 6 additions & 1 deletion

File tree

frontend/src/components/common/Resource/RestartButton.stories.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ const mockDeployment = new Deployment({
4343
},
4444
spec: {
4545
replicas: 3,
46+
selector: { matchLabels: { app: 'headlamp' } },
4647
template: {
4748
spec: {
4849
nodeName: 'mock-node',

frontend/src/components/common/Resource/ScaleButton.stories.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ const mockDeployment = new Deployment({
4545
},
4646
spec: {
4747
replicas: 3,
48+
selector: { matchLabels: { app: 'headlamp' } },
4849
template: {
4950
spec: {
5051
nodeName: 'mock-node',

frontend/src/lib/k8s/deployment.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export type { RollbackResult };
2828

2929
export interface KubeDeployment extends KubeObjectInterface {
3030
spec: {
31-
selector?: LabelSelector;
31+
selector: LabelSelector;
3232
strategy?: {
3333
type: string;
3434
[otherProps: string]: any;
@@ -37,6 +37,9 @@ export interface KubeDeployment extends KubeObjectInterface {
3737
metadata?: KubeMetadata;
3838
spec: KubePodSpec;
3939
};
40+
minReadySeconds?: number;
41+
progressDeadlineSeconds?: number;
42+
revisionHistoryLimit?: number;
4043
[otherProps: string]: any;
4144
};
4245
status: {

0 commit comments

Comments
 (0)