Skip to content

Commit c652930

Browse files
AtsushiMclaude
andauthored
refactor!: RemoteTriggerダイアログのプレフィックスを削除して推奨版として提供 (#6196)
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent e4a27d7 commit c652930

14 files changed

Lines changed: 51 additions & 56 deletions

File tree

packages/smarthr-ui/src/components/Dialog/ControlledActionDialog/stories/ActionDialog.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export default {
3838
)
3939
},
4040
args: {
41-
heading: 'ダイアログタイトル',
41+
heading: 'アクションダイアログ(Controlled)',
4242
actionText: 'アクションボタンラベル',
4343
},
4444
parameters: {

packages/smarthr-ui/src/components/Dialog/ControlledFormDialog/stories/FormDialog.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export default {
4848
)
4949
},
5050
args: {
51-
heading: 'フォームダイアログ',
51+
heading: 'フォームダイアログ(Controlled)',
5252
actionText: '送信',
5353
},
5454
parameters: {

packages/smarthr-ui/src/components/Dialog/ControlledMessageDialog/stories/MessageDialog.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default {
2121
)
2222
},
2323
args: {
24-
heading: 'メッセージダイアログタイトル',
24+
heading: 'メッセージダイアログ(Controlled)',
2525
children: 'メッセージダイアログ本文',
2626
},
2727
parameters: {

packages/smarthr-ui/src/components/Dialog/RemoteDialogTrigger/RemoteTriggerActionDialog.tsx renamed to packages/smarthr-ui/src/components/Dialog/RemoteDialogTrigger/ActionDialog.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import type { ComponentProps, FC } from 'react'
88
type Props = Omit<ComponentProps<typeof ControlledActionDialog>, 'isOpen' | 'onClickClose' | 'id'> &
99
Parameters<typeof useRemoteTrigger>[0]
1010

11-
export const RemoteTriggerActionDialog: FC<Props> = ({
11+
export const ActionDialog: FC<Props> = ({
1212
id,
1313
onClickClose,
1414
onToggle,

packages/smarthr-ui/src/components/Dialog/RemoteDialogTrigger/RemoteTriggerFormDialog.tsx renamed to packages/smarthr-ui/src/components/Dialog/RemoteDialogTrigger/FormDialog.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import type { ComponentProps, FC } from 'react'
88
type Props = Omit<ComponentProps<typeof ControlledFormDialog>, 'isOpen' | 'onClickClose' | 'id'> &
99
Parameters<typeof useRemoteTrigger>[0]
1010

11-
export const RemoteTriggerFormDialog: FC<Props> = ({
11+
export const FormDialog: FC<Props> = ({
1212
id,
1313
onClickClose,
1414
onToggle,

packages/smarthr-ui/src/components/Dialog/RemoteDialogTrigger/RemoteTriggerMessageDialog.tsx renamed to packages/smarthr-ui/src/components/Dialog/RemoteDialogTrigger/MessageDialog.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ type Props = Omit<
1111
> &
1212
Parameters<typeof useRemoteTrigger>[0]
1313

14-
export const RemoteTriggerMessageDialog: FC<Props> = ({
14+
export const MessageDialog: FC<Props> = ({
1515
id,
1616
onClickClose,
1717
onToggle,

packages/smarthr-ui/src/components/Dialog/RemoteDialogTrigger/RemoteTriggerStepFormDialog.tsx renamed to packages/smarthr-ui/src/components/Dialog/RemoteDialogTrigger/StepFormDialog.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ type Props = Omit<
1111
> &
1212
Parameters<typeof useRemoteTrigger>[0]
1313

14-
export const RemoteTriggerStepFormDialog: FC<Props> = ({
14+
export const StepFormDialog: FC<Props> = ({
1515
id,
1616
onClickClose,
1717
onToggle,
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
export { RemoteDialogTrigger } from './RemoteDialogTrigger'
2-
export { RemoteTriggerMessageDialog } from './RemoteTriggerMessageDialog'
3-
export { RemoteTriggerStepFormDialog } from './RemoteTriggerStepFormDialog'
4-
export { RemoteTriggerFormDialog } from './RemoteTriggerFormDialog'
5-
export { RemoteTriggerActionDialog } from './RemoteTriggerActionDialog'
2+
export { MessageDialog } from './MessageDialog'
3+
export { StepFormDialog } from './StepFormDialog'
4+
export { FormDialog } from './FormDialog'
5+
export { ActionDialog } from './ActionDialog'

packages/smarthr-ui/src/components/Dialog/RemoteDialogTrigger/stories/RemoteTriggerActionDialog.stories.tsx renamed to packages/smarthr-ui/src/components/Dialog/RemoteDialogTrigger/stories/ActionDialog.stories.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,37 @@
11
import { action } from 'storybook/actions'
22

33
import { Button } from '../../../Button'
4+
import { ActionDialog } from '../ActionDialog'
45
import { RemoteDialogTrigger } from '../RemoteDialogTrigger'
5-
import { RemoteTriggerActionDialog } from '../RemoteTriggerActionDialog'
66

77
import type { Meta, StoryObj } from '@storybook/react-webpack5'
88

99
/** props は [ActionDialog](./?path=/docs/dialog(ダイアログ)-dialog-actiondialog--docs) を参照してください。 */
1010
export default {
11-
title: 'Components/Dialog/RemoteDialogTrigger/RemoteTriggerActionDialog',
12-
component: RemoteTriggerActionDialog,
11+
title: 'Components/Dialog/RemoteDialogTrigger/ActionDialog',
12+
component: ActionDialog,
1313
render: (args) => (
1414
<>
1515
<RemoteDialogTrigger targetId="remote-dialog">
1616
<Button>ダイアログを開く</Button>
1717
</RemoteDialogTrigger>
18-
<RemoteTriggerActionDialog
18+
<ActionDialog
1919
{...args}
2020
id="remote-dialog"
21-
heading="リモートトリガーアクションダイアログ"
21+
heading="アクションダイアログ"
2222
actionText="アクション"
2323
onClickAction={(e, { close }) => {
2424
action('onClickAction')(e)
2525
close()
2626
}}
2727
>
28-
<p>リモートトリガーアクションダイアログです</p>
29-
</RemoteTriggerActionDialog>
28+
<p>アクションダイアログです</p>
29+
</ActionDialog>
3030
</>
3131
),
3232
parameters: {
3333
chromatic: { disableSnapshot: true },
3434
},
35-
} as Meta<typeof RemoteTriggerActionDialog>
35+
} as Meta<typeof ActionDialog>
3636

37-
export const Playground: StoryObj<typeof RemoteTriggerActionDialog> = {}
37+
export const Playground: StoryObj<typeof ActionDialog> = {}

packages/smarthr-ui/src/components/Dialog/RemoteDialogTrigger/stories/RemoteTriggerFormDialog.stories.tsx renamed to packages/smarthr-ui/src/components/Dialog/RemoteDialogTrigger/stories/FormDialog.stories.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,37 @@
11
import { action } from 'storybook/actions'
22

33
import { Button } from '../../../Button'
4+
import { FormDialog } from '../FormDialog'
45
import { RemoteDialogTrigger } from '../RemoteDialogTrigger'
5-
import { RemoteTriggerFormDialog } from '../RemoteTriggerFormDialog'
66

77
import type { Meta, StoryObj } from '@storybook/react-webpack5'
88

99
/** props は [FormDialog](./?path=/docs/dialog(ダイアログ)-dialog-formdialog--docs) を参照してください。 */
1010
export default {
11-
title: 'Components/Dialog/RemoteDialogTrigger/RemoteTriggerFormDialog',
12-
component: RemoteTriggerFormDialog,
11+
title: 'Components/Dialog/RemoteDialogTrigger/FormDialog',
12+
component: FormDialog,
1313
render: (args) => (
1414
<>
1515
<RemoteDialogTrigger targetId="remote-dialog">
1616
<Button>ダイアログを開く</Button>
1717
</RemoteDialogTrigger>
18-
<RemoteTriggerFormDialog
18+
<FormDialog
1919
{...args}
2020
id="remote-dialog"
21-
heading="リモートトリガーフォームダイアログ"
21+
heading="フォームダイアログ"
2222
actionText="アクション"
2323
onSubmit={(e, { close }) => {
2424
action('onSubmit')(e)
2525
close()
2626
}}
2727
>
28-
<p>リモートトリガーフォームダイアログです</p>
29-
</RemoteTriggerFormDialog>
28+
<p>フォームダイアログです</p>
29+
</FormDialog>
3030
</>
3131
),
3232
parameters: {
3333
chromatic: { disableSnapshot: true },
3434
},
35-
} as Meta<typeof RemoteTriggerFormDialog>
35+
} as Meta<typeof FormDialog>
3636

37-
export const Playground: StoryObj<typeof RemoteTriggerFormDialog> = {}
37+
export const Playground: StoryObj<typeof FormDialog> = {}

0 commit comments

Comments
 (0)