Skip to content

[Merged by Bors] - chore(Topology): fix whitespace#32963

Closed
harahu wants to merge 5 commits intoleanprover-community:masterfrom
harahu:chore/lint-topology
Closed

[Merged by Bors] - chore(Topology): fix whitespace#32963
harahu wants to merge 5 commits intoleanprover-community:masterfrom
harahu:chore/lint-topology

Conversation

@harahu
Copy link
Copy Markdown
Contributor

@harahu harahu commented Dec 16, 2025

Found by extending the commandStart linter to proof bodies.


Open in Gitpod

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Dec 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 16, 2025

PR summary 7034fdc072

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@harahu harahu force-pushed the chore/lint-topology branch from 52a9307 to 93815a2 Compare December 16, 2025 13:19
@harahu harahu marked this pull request as ready for review December 16, 2025 13:19
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment; not exhaustive yet

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 16, 2025
@harahu harahu force-pushed the chore/lint-topology branch from 93815a2 to c9b5dfb Compare December 16, 2025 19:27
@harahu
Copy link
Copy Markdown
Contributor Author

harahu commented Dec 16, 2025

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 16, 2025
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 16, 2025
@harahu
Copy link
Copy Markdown
Contributor Author

harahu commented Dec 16, 2025

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 16, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 16, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 16, 2025
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Dec 17, 2025

Thanks!
bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 17, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 17, 2025
Found by extending the commandStart linter to proof bodies.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 17, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Topology): fix whitespace [Merged by Bors] - chore(Topology): fix whitespace Dec 17, 2025
@mathlib-bors mathlib-bors bot closed this Dec 17, 2025
@harahu harahu deleted the chore/lint-topology branch December 17, 2025 23:25
YuvalFilmus pushed a commit to YuvalFilmus/mathlib4 that referenced this pull request Dec 19, 2025
Found by extending the commandStart linter to proof bodies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants