Skip to content

[Merged by Bors] - chore: golf proofs#32996

Closed
euprunin wants to merge 6 commits intoleanprover-community:masterfrom
euprunin:golf-dxxx
Closed

[Merged by Bors] - chore: golf proofs#32996
euprunin wants to merge 6 commits intoleanprover-community:masterfrom
euprunin:golf-dxxx

Conversation

@euprunin
Copy link
Copy Markdown
Contributor

@euprunin euprunin commented Dec 17, 2025


Trace profiling results (shown if ≥10 ms before or after):

  • SimpleGraph.Walk.nil_takeUntil: 88 ms before, <10 ms after 🎉
  • Monoid.CoprodI.induction_on: <10 ms before, <10 ms after 🎉
  • MulChar.ext': <10 ms before, <10 ms after 🎉

This golfing PR is batched under the following guidelines:

  • Up to ~5 changed files per PR
  • Up to ~25 changed declarations per PR
  • Up to ~100 changed lines per PR

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 17, 2025

PR summary 25ce633136

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 17, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 18, 2025
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 19, 2025
@euprunin euprunin removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 19, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 19, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 19, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 19, 2025

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Dec 19, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 19, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: golf proofs [Merged by Bors] - chore: golf proofs Dec 19, 2025
@mathlib-bors mathlib-bors bot closed this Dec 19, 2025
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants