[Merged by Bors] - perf(Translate): don't actually beta reduce the proof#37776
Closed
JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - perf(Translate): don't actually beta reduce the proof#37776JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary cb3293da5dImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
Author
|
!bench |
|
Benchmark results for 3e3c9a1 against cb3293d are in. Significant changes detected! @JovanGerb
No significant changes detected. |
Contributor
Author
|
Let's try again !bench |
|
Benchmark results for 96c28d5 against cb3293d are in. Significant changes detected! @JovanGerb
Large changes (4✅, 14🟥)
Medium changes (10🟥)
Small changes (2✅, 10🟥)
and 1 hidden |
Contributor
|
Thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
This PR does the fix of #37756 without actually beta reducing any terms. It turns out that sometimes beta reducing can be very expensive. (I knew that this is true in theory, but I'm surprised that it's also true in practice)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the fix of #37756 without actually beta reducing any terms. It turns out that sometimes beta reducing can be very expensive. (I knew that this is true in theory, but I'm surprised that it's also true in practice)