Skip to content

Commit 9f1452d

Browse files
Import DEFAULT_MAX_TOTAL_ROWS / DEFAULT_MAX_CONTINUATION_FRAMES from dqlitewire
Replace inline 10_000_000 / 100_000 literals across the public connect / create_pool / DqliteConnection / ConnectionPool / ClusterClient.connect / DqliteProtocol entry points with the canonical named constants from the wire layer. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 5f3b682 commit 9f1452d

5 files changed

Lines changed: 38 additions & 12 deletions

File tree

src/dqliteclient/__init__.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,12 @@
2323
)
2424
from dqliteclient.node_store import MemoryNodeStore, NodeInfo, NodeStore
2525
from dqliteclient.pool import ConnectionPool
26+
from dqlitewire import (
27+
DEFAULT_MAX_CONTINUATION_FRAMES as _DEFAULT_MAX_CONTINUATION_FRAMES,
28+
)
29+
from dqlitewire import (
30+
DEFAULT_MAX_TOTAL_ROWS as _DEFAULT_MAX_TOTAL_ROWS,
31+
)
2632

2733
__version__ = "0.1.3"
2834

@@ -54,8 +60,8 @@ async def connect(
5460
*,
5561
database: str = "default",
5662
timeout: float = 10.0,
57-
max_total_rows: int | None = 10_000_000,
58-
max_continuation_frames: int | None = 100_000,
63+
max_total_rows: int | None = _DEFAULT_MAX_TOTAL_ROWS,
64+
max_continuation_frames: int | None = _DEFAULT_MAX_CONTINUATION_FRAMES,
5965
trust_server_heartbeat: bool = False,
6066
close_timeout: float = 0.5,
6167
) -> DqliteConnection:
@@ -105,8 +111,8 @@ async def create_pool(
105111
timeout: float = 10.0,
106112
cluster: ClusterClient | None = None,
107113
node_store: NodeStore | None = None,
108-
max_total_rows: int | None = 10_000_000,
109-
max_continuation_frames: int | None = 100_000,
114+
max_total_rows: int | None = _DEFAULT_MAX_TOTAL_ROWS,
115+
max_continuation_frames: int | None = _DEFAULT_MAX_CONTINUATION_FRAMES,
110116
trust_server_heartbeat: bool = False,
111117
close_timeout: float = 0.5,
112118
) -> ConnectionPool:

src/dqliteclient/cluster.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@
1717
from dqliteclient.node_store import MemoryNodeStore, NodeStore
1818
from dqliteclient.protocol import DqliteProtocol
1919
from dqliteclient.retry import retry_with_backoff
20+
from dqlitewire import (
21+
DEFAULT_MAX_CONTINUATION_FRAMES as _DEFAULT_MAX_CONTINUATION_FRAMES,
22+
)
23+
from dqlitewire import (
24+
DEFAULT_MAX_TOTAL_ROWS as _DEFAULT_MAX_TOTAL_ROWS,
25+
)
2026
from dqlitewire import NodeRole
2127
from dqlitewire.messages.responses import _sanitize_server_text as _sanitize_display_text
2228

@@ -386,8 +392,8 @@ async def connect(
386392
self,
387393
database: str = "default",
388394
*,
389-
max_total_rows: int | None = 10_000_000,
390-
max_continuation_frames: int | None = 100_000,
395+
max_total_rows: int | None = _DEFAULT_MAX_TOTAL_ROWS,
396+
max_continuation_frames: int | None = _DEFAULT_MAX_CONTINUATION_FRAMES,
391397
trust_server_heartbeat: bool = False,
392398
close_timeout: float = 0.5,
393399
max_attempts: int | None = None,

src/dqliteclient/connection.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
DqliteProtocol,
2424
_validate_positive_int_or_none,
2525
)
26+
from dqlitewire import DEFAULT_MAX_CONTINUATION_FRAMES as _DEFAULT_MAX_CONTINUATION_FRAMES
27+
from dqlitewire import DEFAULT_MAX_TOTAL_ROWS as _DEFAULT_MAX_TOTAL_ROWS
2628
from dqlitewire import LEADER_ERROR_CODES as _LEADER_ERROR_CODES
2729
from dqlitewire import TX_AUTO_ROLLBACK_PRIMARY_CODES as _TX_AUTO_ROLLBACK_PRIMARY_CODES
2830
from dqlitewire import primary_sqlite_code as _primary_sqlite_code
@@ -324,8 +326,8 @@ def __init__(
324326
*,
325327
database: str = "default",
326328
timeout: float = 10.0,
327-
max_total_rows: int | None = 10_000_000,
328-
max_continuation_frames: int | None = 100_000,
329+
max_total_rows: int | None = _DEFAULT_MAX_TOTAL_ROWS,
330+
max_continuation_frames: int | None = _DEFAULT_MAX_CONTINUATION_FRAMES,
329331
trust_server_heartbeat: bool = False,
330332
close_timeout: float = 0.5,
331333
) -> None:

src/dqliteclient/pool.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,12 @@
2323
)
2424
from dqliteclient.node_store import NodeStore
2525
from dqliteclient.protocol import _validate_positive_int_or_none
26+
from dqlitewire import (
27+
DEFAULT_MAX_CONTINUATION_FRAMES as _DEFAULT_MAX_CONTINUATION_FRAMES,
28+
)
29+
from dqlitewire import (
30+
DEFAULT_MAX_TOTAL_ROWS as _DEFAULT_MAX_TOTAL_ROWS,
31+
)
2632

2733
__all__ = ["ConnectionPool"]
2834

@@ -107,8 +113,8 @@ def __init__(
107113
timeout: float = 10.0,
108114
cluster: ClusterClient | None = None,
109115
node_store: NodeStore | None = None,
110-
max_total_rows: int | None = 10_000_000,
111-
max_continuation_frames: int | None = 100_000,
116+
max_total_rows: int | None = _DEFAULT_MAX_TOTAL_ROWS,
117+
max_continuation_frames: int | None = _DEFAULT_MAX_CONTINUATION_FRAMES,
112118
trust_server_heartbeat: bool = False,
113119
close_timeout: float = 0.5,
114120
) -> None:

src/dqliteclient/protocol.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,12 @@
77
from typing import Any
88

99
from dqliteclient.exceptions import DqliteConnectionError, OperationalError, ProtocolError
10+
from dqlitewire import (
11+
DEFAULT_MAX_CONTINUATION_FRAMES as _DEFAULT_MAX_CONTINUATION_FRAMES,
12+
)
13+
from dqlitewire import (
14+
DEFAULT_MAX_TOTAL_ROWS as _DEFAULT_MAX_TOTAL_ROWS,
15+
)
1016
from dqlitewire import MessageDecoder, MessageEncoder
1117
from dqlitewire.exceptions import (
1218
ProtocolError as _WireProtocolError,
@@ -94,8 +100,8 @@ def __init__(
94100
reader: asyncio.StreamReader,
95101
writer: asyncio.StreamWriter,
96102
timeout: float = 10.0,
97-
max_total_rows: int | None = 10_000_000,
98-
max_continuation_frames: int | None = 100_000,
103+
max_total_rows: int | None = _DEFAULT_MAX_TOTAL_ROWS,
104+
max_continuation_frames: int | None = _DEFAULT_MAX_CONTINUATION_FRAMES,
99105
trust_server_heartbeat: bool = False,
100106
address: str | None = None,
101107
) -> None:

0 commit comments

Comments
 (0)