Merge pull request #56 from thaJeztah/rm_deprecated_IsConsole

thaJeztah · web-flow · commit d342b58f2b23 · 2026-02-09T22:44:46.000+01:00
windows: remove deprecated IsConsole function
diff --git a/windows/console.go b/windows/console.go
@@ -24,14 +24,6 @@ func GetHandleInfo(in interface{}) (uintptr, bool) {
 	}
 }
 
-// IsConsole returns true if the given file descriptor is a Windows Console.
-// The code assumes that GetConsoleMode will return an error for file descriptors that are not a console.
-//
-// Deprecated: use [windows.GetConsoleMode] or [golang.org/x/term.IsTerminal].
-func IsConsole(fd uintptr) bool {
-	return isConsole(fd)
-}
-
 func isConsole(fd uintptr) bool {
 	var mode uint32
 	err := windows.GetConsoleMode(windows.Handle(fd), &mode)

Original file line number	Diff line number	Diff line change
`@@ -24,14 +24,6 @@ func GetHandleInfo(in interface{}) (uintptr, bool) {`
`24`	`24`	`}`
`25`	`25`	`}`
`26`	`26`
`27`		`-// IsConsole returns true if the given file descriptor is a Windows Console.`
`28`		`-// The code assumes that GetConsoleMode will return an error for file descriptors that are not a console.`
`29`		`-//`
`30`		`-// Deprecated: use [windows.GetConsoleMode] or [golang.org/x/term.IsTerminal].`
`31`		`-func IsConsole(fd uintptr) bool {`
`32`		`- return isConsole(fd)`
`33`		`-}`
`34`		`-`
`35`	`27`	`func isConsole(fd uintptr) bool {`
`36`	`28`	`var mode uint32`
`37`	`29`	`err := windows.GetConsoleMode(windows.Handle(fd), &mode)`